Skip to content

[WCM] Document new min_depth configuration option #8185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

james-johnston-thumbtack
Copy link
Contributor

Documentation for new min_depth configuration option in DebugBundle. (This configuration option is pending code review/merge.)

@xabbuh xabbuh added the On hold label Jul 18, 2017
@xabbuh xabbuh added this to the 3.4 milestone Jul 18, 2017
nicolas-grekas added a commit to symfony/symfony that referenced this pull request Jul 19, 2017
…johnston-thumbtack)

This PR was merged into the 3.4 branch.

Discussion
----------

[DebugBundle] Added min_depth to Configuration

This enables calling the recently-added `setMinDepth` function on `VarCloner`.

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT
| Doc PR        | symfony/symfony-docs#8185

Commits
-------

30cd70d [DebugBundle] Added min_depth to Configuration
@HeahDude HeahDude removed the On hold label Jul 29, 2017
@xabbuh
Copy link
Member

xabbuh commented Aug 1, 2017

Thank you @james-johnston-thumbtack.

@xabbuh xabbuh merged commit c6d9e67 into symfony:3.4 Aug 1, 2017
xabbuh added a commit that referenced this pull request Aug 1, 2017
…johnston-thumbtack)

This PR was merged into the 3.4 branch.

Discussion
----------

[WCM] Document new min_depth configuration option

Documentation for new `min_depth` configuration option in DebugBundle.  (This configuration option is pending code review/merge.)

Commits
-------

c6d9e67 Document new min_depth configuration option
xabbuh added a commit that referenced this pull request Aug 1, 2017
xabbuh added a commit that referenced this pull request Aug 1, 2017
* 3.4: (32 commits)
  [#8185] minor reword
  [#8211] minor reword
  Reword
  Update language.rst
  Mention lazy loading for Doctrine event listeners
  Documented the WebProfilerBundle configuration
  Added a note about the new behavior of BrowserKit and redirects
  Fixed usage of default configuration in PHP
  Some typos
  Add pipe to dump command
  Update event_dispatcher.rst
  Typo fixed in a doctrine docs
  [#8245] link text directly
  Link to '"creating a reproducer" in "reporting a bug"
  Removed an extra line
  Updated xml config
  applying comment from @wouterj
  [Form] [RepeatedType] Update "type" default value
  Adds a missing semicolon
  Added missing "," in encore/legacy-apps doc
  ...
@james-johnston-thumbtack
Copy link
Contributor Author

@xabbuh FYI the "minor reword" commit at e8adb4e

introduces a new typo:
"consistentcwith" on line 41.

@james-johnston-thumbtack james-johnston-thumbtack deleted the DebugBundle-setMinDepth branch August 1, 2017 18:12
xabbuh added a commit that referenced this pull request Aug 2, 2017
@xabbuh
Copy link
Member

xabbuh commented Aug 2, 2017

@james-johnston-thumbtack Thanks for the heads up. This is now fixed in d410c46.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants