[DI] Added _instanceof example #8239
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1e658e to
0e993e5
Compare
|
#8232 has been merged, rebased here. |
xabbuh
reviewed
Aug 4, 2017
service_container/3.3-di-changes.rst
Outdated
| ---------------------------------- | ||
|
|
||
| And the final big change is ``_instanceof``, it acts as a default definition | ||
| template (see `service-33-default_definition`_), but only for service whose |
xabbuh
reviewed
Aug 4, 2017
service_container/3.3-di-changes.rst
Outdated
| 5) Auto-configure with _instanceof | ||
| ---------------------------------- | ||
|
|
||
| And the final big change is ``_instanceof``, it acts as a default definition |
There was a problem hiding this comment.
Let's start a new sentence with it to split this long one.
xabbuh
reviewed
Aug 4, 2017
service_container/3.3-di-changes.rst
Outdated
| And the final big change is ``_instanceof``, it acts as a default definition | ||
| template (see `service-33-default_definition`_), but only for service whose | ||
| class matches a defined one. | ||
| This can be very useful when many services shares some tag that cannot be |
xabbuh
reviewed
Aug 4, 2017
service_container/3.3-di-changes.rst
Outdated
| template (see `service-33-default_definition`_), but only for service whose | ||
| class matches a defined one. | ||
| This can be very useful when many services shares some tag that cannot be | ||
| inherited from abstract definition: |
There was a problem hiding this comment.
"[...] form abstract definitions" or "[...] from an abstract definition"
|
@xabbuh I've addressed your comments, thanks! |
xabbuh
approved these changes
Aug 7, 2017
xabbuh
reviewed
Sep 1, 2017
| ) | ||
| ; | ||
|
|
||
| $this->registerClasses($definition, 'AppBundle\\', '../../src/AppBundle/{Entity,Repository}'); |
There was a problem hiding this comment.
we don't have this in the YAML or XML example
B-Galati
reviewed
Oct 2, 2017
| <services> | ||
| <!-- ... --> | ||
|
|
||
| <instanceof class="AppBundle\Domain\LoaderInterface" public="true"> |
There was a problem hiding this comment.
Looks like it's id instead of class based of my research in the codebase with 3.3
greg0ire
pushed a commit
to greg0ire/symfony-docs
that referenced
this pull request
Oct 9, 2017
|
will be finished in #8496 |
greg0ire
pushed a commit
to greg0ire/symfony-docs
that referenced
this pull request
Oct 9, 2017
greg0ire
pushed a commit
to greg0ire/symfony-docs
that referenced
this pull request
Oct 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7538.
On top of #8232, until this merge please just review b1e658e.