[Lock] Deprecate Filesystem/LockHandler #8243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeahDude
reviewed
Jul 31, 2017
|
|
||
| The ``LockHandler`` class has been deprecated in Symfony 3.4 | ||
| and it will be removed in Symfony 4.0. Use ``SemaphoreStore`` or | ||
| ``FlockStore`` from the `Lock` component instead. |
There was a problem hiding this comment.
"Lock" needs double back sticks too.
console/lockable_trait.rst
Outdated
| creation and release of these locks. | ||
| a single server is to use **locks**. The Lock component provides a | ||
| :ref:`SemaphoreStore <_lock-store-semaphore>` class and a | ||
| :ref:`FlockStore <_lock-store-flock>` class and that eases the creation and |
There was a problem hiding this comment.
"and that eases" => "that ease"?
297f67e to
260c8ed
Compare
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Aug 1, 2017
This PR was merged into the 3.4 branch. Discussion ---------- [Lock] Deprecate Filesystem/LockHandler | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | symfony/symfony-docs#8243 This PR deprecate the `Filesystem\LockHandler` in favor of `Lock\SemaphoreStore` and `Lock\FlockStore`. Commits ------- 67ecc71 Deprecate Filesystem/LockHandler
|
symfony/symfony#23724 has been merged. |
|
This PR should be merged after #7866 |
260c8ed to
800bdd7
Compare
|
Thanks Jérémy. |
javiereguiluz
added a commit
that referenced
this pull request
Jan 9, 2018
…eguiluz) This PR was merged into the 3.4 branch. Discussion ---------- [Lock] Deprecate Filesystem/LockHandler This PR deprecate the Filesystem\LockHandler in favor of Lock\SemaphoreStore and Lock\FlockStore. see: symfony/symfony#23724 Commits ------- cb771c3 Reword af6dc34 Minor reword 800bdd7 Deprecate Filesystem/LockHandler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecate the Filesystem\LockHandler in favor of Lock\SemaphoreStore and Lock\FlockStore.
see: symfony/symfony#23724