Skip to content

Enhanced custom plugin configuration #8286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2017
Merged

Conversation

martijngastkemper
Copy link
Contributor

The example doesn't include a declaration of variable webpack.

@wouterj
Copy link
Member

wouterj commented Sep 2, 2017

👍

status: reviewed

@xabbuh
Copy link
Member

xabbuh commented Sep 3, 2017

Good catch, thanks @martijngastkemper.

@xabbuh xabbuh merged commit df8f028 into symfony:3.3 Sep 3, 2017
xabbuh added a commit that referenced this pull request Sep 3, 2017
This PR was merged into the 3.3 branch.

Discussion
----------

Enhanced custom plugin configuration

The example doesn't include a declaration of variable ``webpack``.

Commits
-------

df8f028 Add require('webpack') to prevent undefined var
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants