Skip to content

First parameter to uniqid must be a string #8312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

First parameter to uniqid must be a string #8312

wants to merge 1 commit into from

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Aug 28, 2017

No description provided.

javiereguiluz
javiereguiluz approved these changes Aug 29, 2017
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can easily be verified here: http://php.net/uniqid

Thanks for fixing it!

@xabbuh xabbuh added this to the 2.7 milestone Aug 30, 2017
@xabbuh
Copy link
Member

xabbuh commented Sep 1, 2017

Thank you @Nyholm.

xabbuh added a commit that referenced this pull request Sep 1, 2017
@xabbuh
minor #8312 First parameter to uniqid must be a string (Nyholm)
9859277 
This PR was submitted for the 3.3 branch but it was merged into the 2.7 branch instead (closes #8312).

Discussion
----------

First parameter to uniqid must be a string

Commits
-------

3aac7c5 First parameter to uniqid must be a string
@xabbuh xabbuh closed this Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
4 participants
@Nyholm @xabbuh @javiereguiluz @carsonbot