Page creation article #8394
Merged
Page creation article #8394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ler\Controller;" before Lucky Controller extends the base controller class. This was mentioned in the code but could easily have been missed as a step. I missed that and didn't realize it was a new line in the code. I think the necessary Framework bundles should all have been listed.
xabbuh
reviewed
Sep 15, 2017
page_creation.rst
Outdated
| @@ -48,7 +48,7 @@ random) number and prints it. To do that, create a "Controller class" and a | |||
| class LuckyController | |||
| { | |||
| /** | |||
| * @Route("/lucky/number") | |||
| @Route("/lucky/number") | |||
xabbuh
reviewed
Sep 15, 2017
page_creation.rst
Outdated
| @@ -94,7 +94,10 @@ If you're returning HTML from your controller, you'll probably want to render | |||
| a template. Fortunately, Symfony comes with `Twig`_: a templating language that's | |||
| easy, powerful and actually quite fun. | |||
|
|
|||
| First, make sure that ``LuckyController`` extends Symfony's base | |||
| First, include the Symfony controller class as shown in line 5 below then, | |||
xabbuh
approved these changes
Sep 15, 2017
|
I thought I cancelled it. I am sorry if it came in. My first GIT commit but I didn't complete the pull request. I did a recheck before I completing the process and everything surprisingly worked so I stopped. New to smfony. Actually a Drupal developer and then realized a need to understand how Symfony works. Having composer night mares here. Great job you guys are doing.
I did have issues with this though.origin git@github.com:YOUR-GITHUB-USERNAME/symfony-docs.git (fetch)
origin git@github.com:YOUR-GITHUB-USERNAME/symfony-docs.git (push)
upstream https://github.com/symfony/symfony-docs.git (fetch)
upstream https://github.com/symfony/symfony-docs.git (push) Had to change origin URL to "https" to get it to work. i.e https://github.com/tiwiex/symfony-docs.gitorigin https://github.com/tiwiex/symfony-docs.git (fetch)origin https://github.com/tiwiex/symfony-docs.git (push)upstream https://github.com/symfony/symfony-docs.git (fetch)upstream https://github.com/symfony/symfony-docs.git (push)
Is this something I could have done differently or a change needs to be made?
Regards,Taiwo
The most terrifying words in the english language are "I'm from the government and I am here to help" - Ronald Reagan
On Friday, September 15, 2017 7:48 AM, Christian Flothmann <notifications@github.com> wrote:
@xabbuh commented on this pull request.In page_creation.rst:> @@ -48,7 +48,7 @@ random) number and prints it. To do that, create a "Controller class" and a
class LuckyController
{
/**
- * @route("/lucky/number")
+ @route("/lucky/number")
this change looks wrong—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
javiereguiluz
approved these changes
Oct 4, 2017
|
Thank you @tiwiex. |
xabbuh
added a commit
that referenced
this pull request
Oct 13, 2017
This PR was merged into the 2.7 branch. Discussion ---------- Page creation article included some clarity on creating the controller bundle. not a syntax error. The step is hidden in the code while the instruction to extend Symfony Controller with the LuckyController. Commits ------- d2ff7d6 Rewords d89d2b2 added the step to include "use Symfony\Bundle\FrameworkBundle\Controller\Controller;" before Lucky Controller extends the base controller class. This was mentioned in the code but could easily have been missed as a step. I missed that and didn't realize it was a new line in the code. I think the necessary Framework bundles should all have been listed. 9e9f28e Uncommemted line 10: ** @route("/lucky/number"). I was getting a routing error.
weaverryan
added a commit
that referenced
this pull request
Oct 29, 2017
* 2.7: (34 commits) Update questionhelper.rst Docs re-org and removal of small sections Fix a small typo error (number.rst) Remove deprecated proxy argument Fix instance of class in express language in DI Missing use reference Unused Private param in documentation Doctrine event listener could persist a null value Minor syntax issue Changing type definition Closure by callable Minor syntax issues Fix code-block Add GroupSequence validation_groups capability doc Assume php7 Form - fix wrong submit button label added link to subscribe to a paid plan on platform.sh Use OpenSSL instead of Mcrypt in the examples [#8394] minor reword Minor reword Referencing custom encoders as named encoders ...
weaverryan
added a commit
that referenced
this pull request
Oct 29, 2017
* 2.8: (34 commits) Update questionhelper.rst Docs re-org and removal of small sections Fix a small typo error (number.rst) Remove deprecated proxy argument Fix instance of class in express language in DI Missing use reference Unused Private param in documentation Doctrine event listener could persist a null value Minor syntax issue Changing type definition Closure by callable Minor syntax issues Fix code-block Add GroupSequence validation_groups capability doc Assume php7 Form - fix wrong submit button label added link to subscribe to a paid plan on platform.sh Use OpenSSL instead of Mcrypt in the examples [#8394] minor reword Minor reword Referencing custom encoders as named encoders ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
included some clarity on creating the controller bundle. not a syntax error. The step is hidden in the code while the instruction to extend Symfony Controller with the LuckyController.