Minor reword in autowiring introduction #8606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
approved these changes
Nov 9, 2017
| actionable exception. | ||
| Autowiring allows you to manage services in the container with minimal | ||
| configuration. It reads the type-hints on your constructor (or other methods) | ||
| and automatically passes the correct services to each method. Symfony's |
There was a problem hiding this comment.
"to them" ? (constructor or other methods)
|
I like it as-is. It's much better indeed. Thanks! |
weaverryan
added a commit
that referenced
this pull request
Nov 10, 2017
This PR was merged into the 3.3 branch. Discussion ---------- Minor reword in autowiring introduction I used this in the reword of the Best Practices docs and Fabien [added this comment](#8599 (comment)) because he didn't like a phrase of this paragraph. This PR changes that too here. Commits ------- c84cff8 Minor reword in autowiring introduction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used this in the reword of the Best Practices docs and Fabien added this comment because he didn't like a phrase of this paragraph. This PR changes that too here.