Skip to content

Updated the main bundles article for Symfony 4 #8613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

javiereguiluz
Copy link
Member

I've removed the Bundle Directory Structure contents ... but I plan to move them to other bundle articles in a separate PR.

xabbuh added a commit that referenced this pull request Nov 10, 2017
This PR was merged into the 2.7 branch.

Discussion
----------

Fixed a RST link in the main bundles article

Spotted while working on #8613.

Commits
-------

f152ebb Fixed a RST link in the main bundles article
are used by your application (including the core Symfony bundles).
.. caution::

In Symfony versions prior to 4.0, it was recommended to organize your own
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not really agree with this sentence. At least, it is a bit confusing as we didn't recommend to use bundles, but there only was a single AppBundle. I think that's not really clear right now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need more opinions here, but I thought this:

  • Symfony 2: organize your own code in bundles (1 bundle per feature: UserBundle, ProuctBundle, ...)
  • Symfony 3: organize your own code in bundles (just 1 bundle per app: AppBundle)

Saying: "in prior Sf versions we recommended you to organize your own code in bundles" is compatible with that (in my opinion).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @javiereguiluz here. "organize in bundles" doesn't have to refer to multiple bundles

@javiereguiluz javiereguiluz added this to the 4.0 milestone Nov 10, 2017
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An article describing how to create a bundle is now badly needed, but I agree with the changes in this PR!

are used by your application (including the core Symfony bundles).
.. caution::

In Symfony versions prior to 4.0, it was recommended to organize your own
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @javiereguiluz here. "organize in bundles" doesn't have to refer to multiple bundles

bundles.rst Outdated
In Symfony versions prior to 4.0, it was recommended to organize your own
application code using bundles. This is no longer recommended and bundles
should only be used as third-party plugins that add features in your
applications.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"third-party" refers to another party, but it's perfectly fine to use a bundle made by your own company. What about:

This is no longer recommended and bundles should only be used to share code and features between multiple applications.

bundles.rst Outdated
* :doc:`/bundles/installation`
* :doc:`/bundles/remove`
* :doc:`/bundles/override`
* :doc:`/bundles/inheritance`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's stop linking to this - it'll still be findable by Google.

bundles.rst Outdated
:glob:

bundles/*
* :doc:`/bundles/installation`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And let's remove this link - I'm going to open a PR to remove this entirely

@wouterj
Copy link
Member

wouterj commented Nov 13, 2017

Woohooo, just another article updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants