Document allow outdated vendors mode #8686
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Nov 17, 2017
|
I wonder if should add a table to recommend a usage:
|
rzilin
approved these changes
Jan 29, 2018
6301a75 to
9e6d8b0
Compare
|
Here is how the table looks:
|
OskarStark
reviewed
Jan 30, 2018
components/phpunit_bridge.rst
Outdated
| own dependencies, meaning they do not fix deprecations as soon as | ||
| possible, which means there is nothing you can do to fix that (apart | ||
| from a pull request on the outdated vendor). This mode allows you to | ||
| ignore those deprecations, allowing you to notice when your code is |
There was a problem hiding this comment.
maybe display your code bold?
There was a problem hiding this comment.
Or even better, italics.
OskarStark
reviewed
Jan 30, 2018
|
|
||
| +------------------------+-----------------------------------------------------+ | ||
| | Mode | Recommended situation | | ||
| +========================+=====================================================+ |
There was a problem hiding this comment.
Recommended repeats a lot
There was a problem hiding this comment.
Yeah, not sure what to do about that…
eea6f57 to
e7dee0c
Compare
|
@greg0ire the related PR (symfony/symfony#24867) was closed. Could you please tell us if this PR is still relevant or another one is needed to document the changes mentioned in the closed PR? Thanks! |
|
@javiereguiluz this should be closed for now, sorry for leaving it open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs symfony/symfony#24867