Skip to content

Removed checkDNS option in Url constraint #8921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Removed checkDNS option in Url constraint #8921

wants to merge 1 commit into from

Conversation

ro0NL
Copy link
Contributor

@ro0NL ro0NL commented Dec 22, 2017

@xabbuh xabbuh added this to the 4.1 milestone Dec 22, 2017
@xabbuh xabbuh added the Waiting Code Merge Docs for features pending to be merged label Dec 22, 2017
fabpot added a commit to symfony/symfony that referenced this pull request Dec 31, 2017
…aint (ro0NL)

This PR was squashed before being merged into the 4.1-dev branch (closes #25516).

Discussion
----------

[Validator] Deprecated "checkDNS" option in Url constraint

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #23538
| License       | MIT
| Doc PR        | symfony/symfony-docs#8921

Commits
-------

70d15ca [Validator] Deprecated "checkDNS" option in Url constraint
@javiereguiluz javiereguiluz removed the Waiting Code Merge Docs for features pending to be merged label Jan 2, 2018
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The related code PR was merged, so this is ready to be merged.

@javiereguiluz
Copy link
Member

Closing in favor of #8961.

@ro0NL ro0NL deleted the patch-2 branch January 2, 2018 15:10
javiereguiluz added a commit that referenced this pull request Jan 4, 2018
…iluz)

This PR was merged into the master branch.

Discussion
----------

Deprecated the checkDNS and dnsMessage options

Alternative to #8921 because this feature was deprecated but not removed in 4.1, so we cannot remove the docs yet.

Commits
-------

69788ab Deprecated the checkDNS and dnsMessage options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants