Skip to content

add default option value for collection type #9014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2018
Merged

add default option value for collection type #9014

merged 1 commit into from
Jan 8, 2018

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jan 8, 2018

No description provided.

@xabbuh xabbuh added this to the 2.7 milestone Jan 8, 2018
@xabbuh
Copy link
Member Author

xabbuh commented Jan 8, 2018

see https://github.com/symfony/symfony/blob/2.7/src/Symfony/Component/Form/Extension/Core/Type/CollectionType.php#L89

HeahDude
HeahDude approved these changes Jan 8, 2018
View reviewed changes
Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thx! To replace by the FQCN when merging in newer branches of course ;)

@xabbuh
Copy link
Member Author

xabbuh commented Jan 8, 2018

To replace by the FQCN when merging in newer branches of course ;)

That's already the case thanks to #8831 :)

@javiereguiluz
Copy link
Member

Thanks Christian.

@javiereguiluz javiereguiluz merged commit 96f608a into symfony:2.7 Jan 8, 2018
javiereguiluz added a commit that referenced this pull request Jan 8, 2018
@javiereguiluz
minor #9014 add default option value for collection type (xabbuh)
37d87a0 
This PR was merged into the 2.7 branch.

Discussion
----------

add default option value for collection type

Commits
-------

96f608a add default option value for collection type
@xabbuh xabbuh deleted the pr-8831 branch January 8, 2018 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeahDude HeahDude HeahDude approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @javiereguiluz @HeahDude @carsonbot