Skip to content

Recommend being lenient only with other vendors #9062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2018

Conversation

greg0ire
Copy link
Contributor

If a bundle introduces a deprecation, it should not use the deprecated
path itself anymore.

If a bundle introduces a deprecation, it should not use the deprecated
 path itself anymore.
@stof
Copy link
Member

stof commented Jan 15, 2018

indeed, much better. This mode was not available yet when I wrote the config files which served as inspiration to this recommendation, but it is indeed a better idea.

@javiereguiluz
Copy link
Member

@greg0ire thanks for this. Two quick questions:

  • Is this ready on Symfony side or is it still "waiting for some code merge"?
  • Which is the first Symfony version that includes this feature? I guess 4.0 because of the branch of your PR, but let's double check.

Thanks!

@greg0ire
Copy link
Contributor Author

greg0ire commented Jan 15, 2018

Is this ready on Symfony side or is it still "waiting for some code merge"?

This is ready on Symfony side, you may be confused by the upcoming weak_lagging_vendors, which is targetted at project, not libraries, although there is a small bug with the weak_vendors mode, see the fix here : symfony/symfony#24864 (reviews are welcome, it's getting quite old 🕸️ )

Which is the first Symfony version that includes this feature? I guess 4.0 because of the branch of your PR, but let's double check.

It is available since v3.3.0-BETA1 (see symfony/symfony#21539)

@stof
Copy link
Member

stof commented Jan 15, 2018

and note that this is related to the PHPUnit bridge version, which is decoupled from the Symfony version being tested (i.e. bundle should always use ^4.0 for the bridge in their bundle, not older versions, even if they want to support Symfony 2.x)

@javiereguiluz
Copy link
Member

OK thanks. I'm still confused about which branch should I merge this in: 3.3 or 4.0?

@greg0ire
Copy link
Contributor Author

It changes a recently added paragraph by @Nyholm and others. It was added on 4.0. See https://twitter.com/dbu/status/952831321822388225

@javiereguiluz
Copy link
Member

Thank you Grégoire.

@javiereguiluz javiereguiluz merged commit 64a9aa5 into symfony:4.0 Jan 15, 2018
javiereguiluz added a commit that referenced this pull request Jan 15, 2018
This PR was merged into the 4.0 branch.

Discussion
----------

Recommend being lenient only with other vendors

If a bundle introduces a deprecation, it should not use the deprecated
 path itself anymore.

Commits
-------

64a9aa5 Recommend being lenient only with other vendors
@stof
Copy link
Member

stof commented Jan 15, 2018

@javiereguiluz the feature used here exists since SF 3.3. But the article in best practices has this content only for new versions of the doc. This is what creates confusion in the discussion.

@greg0ire greg0ire deleted the patch-9 branch January 15, 2018 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants