Swap $key and $index parameters in ChoiceType #9173
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've noticed the second parameter in the callback function for the options in the ChoiceType represents the index and the third the key. This patch brings the documentation in line with the code.
|
@vudaltsov can you please review if this proposal is correct? Thanks! |
xabbuh
reviewed
Mar 23, 2018
| @@ -92,19 +92,18 @@ method:: | |||
| new Category('Cat3'), | |||
| new Category('Cat4'), | |||
| ], | |||
| 'choice_label' => function($category, $key, $index) { | |||
| 'choice_label' => function($category, $index, $key) { | |||
There was a problem hiding this comment.
function($category, $key, $value)
xabbuh
reviewed
Mar 23, 2018
| /** @var Category $category */ | ||
| return strtoupper($category->getName()); | ||
| }, | ||
| 'choice_attr' => function($category, $key, $index) { | ||
| 'choice_attr' => function($category, $index, $key) { |
There was a problem hiding this comment.
function($category, $key, $value)
xabbuh
reviewed
Mar 23, 2018
| return ['class' => 'category_'.strtolower($category->getName())]; | ||
| }, | ||
|
|
||
| 'group_by' => function($category, $key, $index) { | ||
| 'group_by' => function($category, $index, $key) { |
There was a problem hiding this comment.
function($category, $key, $value)
xabbuh
reviewed
Mar 23, 2018
| @@ -18,7 +18,7 @@ If an array, the keys of the ``choices`` array must be used as keys:: | |||
| 'No' => false, | |||
| 'Maybe' => null, | |||
| ), | |||
| 'choice_attr' => function($val, $key, $index) { | |||
| 'choice_attr' => function($val, $index, $key) { | |||
There was a problem hiding this comment.
function($category, $key, $value)
xabbuh
reviewed
Mar 23, 2018
| @@ -16,7 +16,7 @@ more control:: | |||
| 'no' => false, | |||
| 'maybe' => null, | |||
| ), | |||
| 'choice_label' => function ($value, $key, $index) { | |||
| 'choice_label' => function ($value, $index, $key) { | |||
There was a problem hiding this comment.
function($category, $key, $value)
xabbuh
reviewed
Mar 23, 2018
| @@ -22,7 +22,7 @@ Take the following example:: | |||
| '1 week' => new \DateTime('+1 week'), | |||
| '1 month' => new \DateTime('+1 month') | |||
| ), | |||
| 'group_by' => function($val, $key, $index) { | |||
| 'group_by' => function($val, $index, $key) { | |||
There was a problem hiding this comment.
function($category, $key, $value)
|
I'm afraid this PR stalled and now it has some conflicts. So I've opened #9835 to finish it. Thanks @technetium for opening this and thanks to reviewers. |
javiereguiluz
added a commit
that referenced
this pull request
May 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed the second parameter in the callback function for the
options in the ChoiceType represents the index and the third the
key.
This patch brings the documentation in line with the code.