Skip to content

add Prefixing the Names of Imported Routes #9186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2018
Merged

add Prefixing the Names of Imported Routes #9186

merged 2 commits into from
Feb 7, 2018

Conversation

ismail1432
Copy link
Contributor

This PR follows this one #9159

@javiereguiluz
Copy link
Member

javiereguiluz commented Feb 2, 2018

@ismail1432 I've reviewed your contribution and made some fixes. You may be thinking "he changed everything I contributed!!" but I hope you understand why we made those changes:

  • Syntax issues: Symfony Docs use a very strict format called reStructuredText. That's why the underline of a heading must be of the same length of the heading, the code blocks that contain PHP don't need a .. code-block directive, etc.
  • Content issues: the example you took from the blog post was a bit complex (my bad!) so I've simplified the route config to make things easier to understand.
  • Missing .. versionadded directive: it's needed when we document a new feature so the reader knows when a feature was introduced.

In any case, thanks for your contribution and we hope to get more contributions from you in the future. Thanks!

@ismail1432
Copy link
Contributor Author

No worries @javiereguiluz ! I totally understand.
Thanks for the feedback

@javiereguiluz javiereguiluz merged commit f8b8e0d into symfony:3.4 Feb 7, 2018
javiereguiluz added a commit that referenced this pull request Feb 7, 2018
…aviereguiluz)

This PR was merged into the 3.4 branch.

Discussion
----------

add  Prefixing the Names of Imported Routes

This PR follows this one #9159

Commits
-------

f8b8e0d Some fixes and rewords
5ec506d add  Prefixing the Names of Imported Routes
@xabbuh xabbuh added this to the 3.4 milestone Feb 23, 2018
@xabbuh xabbuh added the Routing label Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants