Documented the missing YAML flags #9205
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Feb 6, 2018
components/yaml.rst
Outdated
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| .. versionadded:: 3.2 | ||
| Support for parsing and dumping objectas as maps was introduced in Symfony 3.2. |
xabbuh
reviewed
Feb 6, 2018
components/yaml.rst
Outdated
| $object->foo = 'bar'; | ||
|
|
||
| $dumped = Yaml::dump(array('data' => $object), 2, 4, Yaml::DUMP_OBJECT_AS_MAP); | ||
| // $dumped = "data:\nfoo:\nSbar" |
There was a problem hiding this comment.
data:\n foo:\nbar because of the indentation, right?
xabbuh
reviewed
Feb 6, 2018
components/yaml.rst
Outdated
|
|
||
| $parsed = Yaml::parse($dumped, Yaml::PARSE_OBJECT); | ||
| var_dump(is_object($parsed)); // true | ||
| echo $parsed->foo; // bar |
There was a problem hiding this comment.
if $dumped has the same value as above, we would need to account for data here or omit it above while dumping
|
@xabbuh thanks for the review. To be 100% sure about the code, I created an snippet and run it to double check the results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finishes #6226.