[FrameworkBundle] feature: add the ability to search for a route #9236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
reviewed
Mar 13, 2018
routing/debug.rst
Outdated
| [1] blog_show | ||
| > | ||
|
|
||
| If you choose ``blog_show`` it will show the route information. |
There was a problem hiding this comment.
What about merging this all in the previous code example, to reduce the amount of text/lines?
You can also get very specific information on a single route by including
the route name as the command argument:
.. code-block:: terminal
$ php bin/console debug:router article_show
# ...
# or use part of the name to search for routes
$ php bin/console debug:router blo
Select one of the following routes to display its information:
[0] blog
[1] blog_show
>There was a problem hiding this comment.
I think we can simply drop the sentence. The CLI example is self-explanatory, isn't it?
There was a problem hiding this comment.
what sentence do you want to drop, the one explaining or the one in the comments?
There was a problem hiding this comment.
this one: "If you choose blog_show it will show the route information."
|
I like the feature! 👍 for when it gets merged |
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Mar 21, 2018
… route (Simperfit) This PR was merged into the 4.1-dev branch. Discussion ---------- [FrameworkBundle] feature: add the ability to search a route | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #26033 | License | MIT | Doc PR | symfony/symfony-docs#9236 This add the ability to search a route in the debug:router command.  Commits ------- ef0df02afc [FrameworkBundle] feature: add the ability to search a route
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Mar 21, 2018
… route (Simperfit) This PR was merged into the 4.1-dev branch. Discussion ---------- [FrameworkBundle] feature: add the ability to search a route | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #26033 | License | MIT | Doc PR | symfony/symfony-docs#9236 This add the ability to search a route in the debug:router command.  Commits ------- ef0df02 [FrameworkBundle] feature: add the ability to search a route
|
PR is ready, updated with the final merged PR on the core. |
xabbuh
approved these changes
Mar 21, 2018
|
Thanks Hamza. |
javiereguiluz
added a commit
that referenced
this pull request
Mar 23, 2018
…a route (Simperfit) This PR was merged into the master branch. Discussion ---------- [FrameworkBundle] feature: add the ability to search for a route The PR add the documentation for core's PR symfony/symfony#26121 Commits ------- 2d781a8 feature: add the ability to search for a route
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR add the documentation for core's PR symfony/symfony#26121