Skip to content

Use the proper path of version 2.x #9294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Use the proper path of version 2.x #9294

wants to merge 1 commit into from

Conversation

Romain
Copy link
Contributor

@Romain Romain commented Feb 19, 2018

This doc used the path added as of version 3.x.
In version 2.x, it has to be app/foo for the commands.

This doc used the path added as of version 3.x.
In version 2.x, it has to be app/foo for the commands.
@javiereguiluz
Copy link
Member

@Romain nice catch! We've merged it on 2.7 branch, the oldest maintained branch that contains the bug. That's why GitHub shows it as closed instead of merged ... but it's merged. Thanks!

javiereguiluz added a commit that referenced this pull request Feb 19, 2018
This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes #9294).

Discussion
----------

Use the proper path of version 2.x

This doc used the path added as of version 3.x.
In version 2.x, it has to be app/foo for the commands.

Commits
-------

9f4cdf7 Use the proper path of version 2.x
@Romain
Copy link
Contributor Author

Romain commented Feb 19, 2018

Thanks @javiereguiluz.
You're right, I was looking at the 2.8 doc, I should have also looked at the 2.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants