Clarification on search user #9307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had issues with configuration because I misunderstood the configuration for the user provider. I didn't realize that the configured user was actually a static one only used for retrieving information. I also added a clarification for the case that you are getting information anonymously, which was what my situation required.
javiereguiluz
previously requested changes
Apr 25, 2018
There was a problem hiding this comment.
Thanks for this contribution but I'd like to ask some changes:
-
We can remove this: "If you wish to keep your password out of version control, you may want to configure the password as a parameter." because we already explain that in other articles and we want to minimize repeated Symfony Docs contents to ease maintenance.
-
I don't understand this phrase: "It's important to note that the user you configure for the user provider is only going to be retrieving data." and this other phrase: "It is a statically defined user and password. "
I wonder if we can reword this as follow:
.. tip::
If your LDAP server allows you to retrieve information anonymously, you
can leave the ``search_dn`` and ``search_password`` as ``null``.|
Thanks for helping us improve Symfony Docs and I'm sorry it took us so long to merge this. |
javiereguiluz
added a commit
that referenced
this pull request
May 28, 2018
This PR was merged into the 2.8 branch. Discussion ---------- Clarification on search user I had issues with configuration because I misunderstood the configuration for the user provider. I didn't realize that the configured user was actually a static one only used for retrieving information. I also added a clarification for the case that you are getting information anonymously, which was what my situation required. These changes are relevant for Symfony 2.8+ (2.8 being the oldest maintained version I checked) Also, I added a note on keeping the password out of VC by using a parameter, but in Symfony 4 this should be an environment variable instead. I'm not sure how I'm supposed to propose the change for this slight difference once hitting that version. Commits ------- b7a2009 Minor reword f08eab2 Clarification on search user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had issues with configuration because I misunderstood the configuration for the user provider. I didn't realize that the configured user was actually a static one only used for retrieving information.
I also added a clarification for the case that you are getting information anonymously, which was what my situation required.
These changes are relevant for Symfony 2.8+ (2.8 being the oldest maintained version I checked)
Also, I added a note on keeping the password out of VC by using a parameter, but in Symfony 4 this should be an environment variable instead. I'm not sure how I'm supposed to propose the change for this slight difference once hitting that version.