Skip to content

Rename allowSuccessfulResponse to correct allowCustomResponseCode #9336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions reference/events.rst
Original file line number Diff line number Diff line change
Expand Up @@ -236,15 +236,15 @@ response:

If you want to overwrite the status code of the exception response, which
you should not without a good reason, call
``GetResponseForExceptionEvent::allowSuccessfulResponse()`` first and then
``GetResponseForExceptionEvent::allowCustomResponseCode()`` first and then
set the status code on the response::

$event->allowSuccessfulResponse();
$event->allowCustomResponseCode();
$response = new Response('No Content', 204);
$event->setResponse($response);

The status code sent to the client in the above example will be ``204``. If
``$event->allowSuccessfulResponse()`` is omitted, then the kernel will set
``$event->allowCustomResponseCode()`` is omitted, then the kernel will set
an appropriate status code based on the type of exception thrown.

.. seealso::
Expand Down