Skip to content

Adding Code of Conduct #9394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 30, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 92 additions & 0 deletions contributing/code_of_conduct/index.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
Code of Conduct
===============

Our Pledge
----------

In the interest of fostering an open and welcoming environment, we as
contributors and maintainers pledge to making participation in our project and
our community a harassment-free experience for everyone, regardless of age, body
size, disability, ethnic origin, gender identity and expression, level of experience,
education, socio-economic status, nationality, personal appearance,
religion, or sexual identity and orientation.

Our Standards
-------------

Examples of behavior that contributes to creating a positive environment
include:

* Using welcoming and inclusive language
* Being respectful of differing viewpoints and experiences
* Gracefully accepting constructive criticism
* Focusing on what is best for the community
* Showing empathy towards other community members

Examples of unacceptable behavior by participants include:

* The use of sexualized language or imagery and unwelcome sexual attention or
advances
* Trolling, insulting/derogatory comments, and personal or political attacks
* Public or private harassment
* Publishing others' private information, such as a physical or electronic
address, without explicit permission
* Other conduct which could reasonably be considered inappropriate in a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still 👎 about this phrase:

  • Other conduct which could reasonably be considered inappropriate in a professional setting.

The reason, as explained multiple times in the other pull request, is that this clause is a backdoor to potential power abuse by the enforcement team.

The other items of the list are perfectly reasonable and perfectly defined: sexualized language, trolling, harassment, doxxing, etc. But the last phrase is a "catch-all" clause that says: we'll ban anything that we consider inappropriate.

Copy link
Contributor

@lsmith77 lsmith77 Mar 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted .. just for the record my previously stated response to this objection:
we cannot realistically list every objectionable behavior. this is not a legal document as we lack the infrastructure to handle rules at this level of detail. I understand the concern for a "power grab", but since the enforcement team is appointed by the core-team, there is still a way to stop the enforcement team if they ever do get out of hand.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have thought about this some more and consulted an expert in code of conduct enforcement. My conclusion is that opening up the records to the entire core team is too much in conflict with insuring privacy. As such I would say its sufficient that if the core team suspects that there is overreach happening, that they simply use the power to change the members in the enforcement team. Of course members of the core team can then also become members of the enforcement team as part of this process. But the goal is to better protect privacy by:

  • limiting access to the records to as few people as possible
  • limiting access to people that have invested time into educating themselves on the topic (and ideally received some formal training).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say its sufficient that if the core team suspects that there is overreach happening, that they simply use the power to change the members in the enforcement team

And how can we know or suspect that if we don't have access to any information? If the entire Core Team is too much, then please give access to a small representation of the Core Team (three people for example).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If people from the core team are interested in the topic enough, then why don't they just become part of the enforcement team?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not about being part of the ET (Enforcement Team) ... we need an outside control of ET to ensure that they don't exceed their competences, that they don't act arbitrarily, etc. It'd be nice if someone (or a small group of people) from the CT (Core Team) watches the ET.

I propose myself as a candidate for that role: overseeing the ET. My proposed workflow would be that the designated person would have full access to all reports and all decisions from the ET. That person won't attend meetings of ET, won't make any decision, won't revoke any decision and won't change anything. If that person thinks that the ET is acting wrongly in some case, he/she will report it to the CT so the entire core team members can make a decision about that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imho this creates more problems than it potentially solves .. not even the ET will have automatic access to all reports since depending on the people involved people will recuse themselves or reports may wish to not include specific people due to certain experiences.

now we would have to also keep some people in the loop that are not even part of the process.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Power Abuse is also a point we can add to the code of conduct.

professional setting

Our Responsibilities
--------------------

:doc:`Enforcement team members </contributing/code_of_conduct/enforcement_team>`
are responsible for clarifying the standards of acceptable
behavior and are expected to take appropriate and fair corrective action in
response to any instances of unacceptable behavior.

Enforcement team members have the right and responsibility to remove, edit, or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like a reword of this:

Enforcement team members have the right [...] to ban temporarily or
permanently any contributor for other behaviors that they deem inappropriate,
threatening, offensive, or harmful.

The phrase reads: "if enforcement members don't consider something appropriate, you will be banned". But it should read, "if enforcement members find something inappropriate according to the CoC, you will be banned".

The enforcement members don't have unlimited power. Punishments must be based on the CoC, not on this team people's opinions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you commented on the wrong line number? 😃

reject comments, commits, code, wiki edits, issues, and other contributions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be wiki pages instead of wiki edits ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe wiki edits has the adding of new wiki pages and the editing of existing ones covered

that are not aligned to this Code of Conduct, or to ban temporarily or
permanently any contributor for other behaviors that they deem inappropriate,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might already have been answered (and sorry if it's the case) but what does that mean to "ban a contributor"? Can't we also "ban" non-contributors? Also, it might be worth clarifying what a "contributor" is because I suspect here we also refer to people who write comments only while somewhere else on the website, "contributors" or just the people who have commits within the codebase.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember it was asked, at least not directly. As I understand it's possible to ban a contributor only on the managed platforms, i.e. github (https://help.github.com/articles/blocking-a-user-from-your-organization/), slack and so on. A contribution is mentioned above as comments, commits, code, wiki edits, issues, and other contributions. While the other contributions is open for interpretation (e.g. a slack conversation).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would see slack included here .. I am hestitant to explicitly mention all our “official” platforms of communication, since it means we need to update this frequently. but if it helps clarity maybe we should?

so what are the official places?

  • github
  • symfony.com
  • slack
  • symfony events

That being said, I am also hoping that some projects within our eco-system start adopting our CoC and enforcement process. So in that respect explicit listing might not be ideal. I was hoping for us to implement GDPR which would have entailed actually asking people to consent to the CoC on all our platforms, which in turn would mean that if anyone also adopts our CoC, they would then ask for consent on those additional platforms.

threatening, offensive, or harmful.

Scope
-----

This Code of Conduct applies both within project spaces and in public spaces
when an individual is representing the project or its community. Examples of
representing a project or community include using an official project e-mail
address, posting via an official social media account, or acting as an appointed
representative at an online or offline event. Representation of a project may be
further defined and clarified by enforcement team members.

Enforcement
-----------

Instances of abusive, harassing, or otherwise unacceptable behavior
:doc:`may be reported </contributing/code_of_conduct/reporting_guidelines>`
by contacting the :doc:`enforcement team members </contributing/code_of_conduct/enforcement_team>`.
All complaints will be reviewed and investigated and will result in a response that
is deemed necessary and appropriate to the circumstances. The enforcement team is
obligated to maintain confidentiality with regard to the reporter of an incident.
Further details of specific enforcement policies may be posted separately.

Enforcement team members who do not follow or enforce the Code of Conduct in good
faith may face temporary or permanent repercussions as determined by the
:doc:`core team </contributing/code/core_team>`.

Attribution
-----------

This Code of Conduct is adapted from the `Contributor Covenant`_, version 1.4,
available at https://www.contributor-covenant.org/version/1/4/code-of-conduct.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that link required here since "Contributor Covenant" is already linked?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! The Contributor Covenant should actually link to https://www.contributor-covenant.org


Related Documents
-----------------

.. toctree::
:maxdepth: 1

reporting_guidelines
enforcement_team
concrete_example_document

.. _Contributor Covenant: https://www.contributor-covenant.org