Documented the "values" option of the Expression constraint #9428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not knowledgable in XML, but this reminds me same issue we had with Workflow metadata. @stof responded with this symfony/symfony#23257 (comment), seems it could be applied here too |
|
@ostrolucky thanks for your help! I did some changes, but we'll need a review here from some XML expert. Thanks! |
wouterj
approved these changes
Mar 13, 2018
reference/constraints/Expression.rst
Outdated
| values | ||
| ~~~~~~ | ||
|
|
||
| **type**: ``array`` **default**: an empty array |
There was a problem hiding this comment.
Don't we use [] in that case? (or just nothing, as empty is like no default)
reference/constraints/Expression.rst
Outdated
|
|
||
| class Analysis | ||
| { | ||
| // ... |
There was a problem hiding this comment.
imo, this and the empty line below can be removed. That saves some lines
|
I can confirm the XML is correct status: reviewed |
ostrolucky
approved these changes
Mar 13, 2018
|
Tried this xml, works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #9098.
@ostrolucky I have problems defining the XML config of this example. Could you please help me? Thanks!