Symfony Messenger component documentation #9437

sroze · 2018-03-14T14:51:47Z

This pull-request adds some documentation for the Messenger component. As it is, it's extracted from the README built incrementally in the code pull-request.

I'm sure there will be lots to change when the implementation is merged :)

…ymfony-docs#9437)

This PR was squashed before being merged into the 4.1-dev branch (closes #24411). Discussion ---------- [Messenger] Add a new Messenger component | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24326 | License | MIT | Doc PR | symfony/symfony-docs#9437 As discussed in #24326. This PR is to help going forward with the discussions of having a Message component. # Resources | What | Where | --- | --- | Documentation | [In the PR](https://github.com/sroze/symfony/blob/add-message-component/src/Symfony/Component/Message/README.md) | Demo | [In `sroze/symfony-demo:message-component-demo`](https://github.com/sroze/symfony-demo/compare/message-component-demo) | [php-enqueue](https://github.com/php-enqueue/enqueue-dev) adapter | 1. Source: [In `sroze/enqueue-bridge`](https://github.com/sroze/enqueue-bridge) _(to be moved as `symfony/enqueue-bridge` I guess)_ 2. Demo: [In `sroze/symfony-demo:message-component-demo-with-enqueue`](sroze/symfony-demo@message-component-demo...sroze:message-component-demo-with-enqueue) | [Swarrot](https://github.com/swarrot/swarrot) adapter | **Outdated adapter, waiting for stabilization** 1. Source: [In `sroze/swarrot-bridge`](https://github.com/sroze/swarrot-bridge) _(to be moved as `symfony/swarrot-bridge` I guess)_ 2. Demo: [In `sroze/symfony-demo:message-component-demo-with-swarrot`](sroze/symfony-demo@message-component-demo...sroze:message-component-demo-with-swarrot) | [HTTP](https://github.com/sroze/message-http-adapter) adapter | **Outdated adapter, waiting for stabilization** 1. Source: [In `sroze/message-http-adapter`](https://github.com/sroze/message-http-adapter) 2. Demo: [In `sroze/symfony-demo:message-component-demo-with-http-adapter`](sroze/symfony-demo@message-component-demo...sroze:message-component-demo-with-http-adapter) | Web profiler integration | _In the pull-request_ # Important points 1. **Tests are not in the PR as they were written in PhpSpec & Behat.** If we decide to go forward with this approach, I'll translate them to PHPUnit. 2. The aim is not to solve all the message/queuing problems but provide a good, simple and extensible message bus for developers. 3. The communication with the actual AMQP/API brokers is down to the adapters for now. Not sure if we need to ship some by default or not 🤔 I guess that this would replace #23842 & #23315. # Changes from the proposals Based on the comments, a few changes have been made from the proposal. 1. `MessageProducer`s have been renamed to `MessageSender`s 2. `MessageConsumer`s have been renamed to `MessageReceiver`s Commits ------- c9cfda990b [Messenger] Add a new Messenger component

This PR was squashed before being merged into the 4.1-dev branch (closes #24411). Discussion ---------- [Messenger] Add a new Messenger component | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24326 | License | MIT | Doc PR | symfony/symfony-docs#9437 As discussed in #24326. This PR is to help going forward with the discussions of having a Message component. # Resources | What | Where | --- | --- | Documentation | [In the PR](https://github.com/sroze/symfony/blob/add-message-component/src/Symfony/Component/Message/README.md) | Demo | [In `sroze/symfony-demo:message-component-demo`](https://github.com/sroze/symfony-demo/compare/message-component-demo) | [php-enqueue](https://github.com/php-enqueue/enqueue-dev) adapter | 1. Source: [In `sroze/enqueue-bridge`](https://github.com/sroze/enqueue-bridge) _(to be moved as `symfony/enqueue-bridge` I guess)_ 2. Demo: [In `sroze/symfony-demo:message-component-demo-with-enqueue`](sroze/symfony-demo@message-component-demo...sroze:message-component-demo-with-enqueue) | [Swarrot](https://github.com/swarrot/swarrot) adapter | **Outdated adapter, waiting for stabilization** 1. Source: [In `sroze/swarrot-bridge`](https://github.com/sroze/swarrot-bridge) _(to be moved as `symfony/swarrot-bridge` I guess)_ 2. Demo: [In `sroze/symfony-demo:message-component-demo-with-swarrot`](sroze/symfony-demo@message-component-demo...sroze:message-component-demo-with-swarrot) | [HTTP](https://github.com/sroze/message-http-adapter) adapter | **Outdated adapter, waiting for stabilization** 1. Source: [In `sroze/message-http-adapter`](https://github.com/sroze/message-http-adapter) 2. Demo: [In `sroze/symfony-demo:message-component-demo-with-http-adapter`](sroze/symfony-demo@message-component-demo...sroze:message-component-demo-with-http-adapter) | Web profiler integration | _In the pull-request_ # Important points 1. **Tests are not in the PR as they were written in PhpSpec & Behat.** If we decide to go forward with this approach, I'll translate them to PHPUnit. 2. The aim is not to solve all the message/queuing problems but provide a good, simple and extensible message bus for developers. 3. The communication with the actual AMQP/API brokers is down to the adapters for now. Not sure if we need to ship some by default or not 🤔 I guess that this would replace #23842 & #23315. # Changes from the proposals Based on the comments, a few changes have been made from the proposal. 1. `MessageProducer`s have been renamed to `MessageSender`s 2. `MessageConsumer`s have been renamed to `MessageReceiver`s Commits ------- c9cfda9 [Messenger] Add a new Messenger component

fabpot · 2018-03-23T08:21:54Z

Should be updated as the component is now named Messenger.

sroze · 2018-03-23T08:23:20Z

Yep. I'll go through the PR and re-phrase a bunch of things this weekend.

minor doc fixes for the Message component

javiereguiluz · 2018-03-23T10:28:28Z

components/message.rst

+=====================
+
+    The Message component helps application to send and receive messages
+    to/from other applications or via


This phrase looks unfinished. Also, it's not a very descriptive description. Should we mention at least "message bus" or some key concept so the readers know undoubtely what problem does this component solve? Thanks!

cafferata · 2018-03-23T10:33:01Z

components/message.rst

+
+    $ composer require symfony/message
+
+Alternatively, you can clone the `<https://github.com/symfony/message>`_ repository.


This should be https://github.com/symfony/messenger.

cafferata · 2018-03-23T10:33:45Z

components/message.rst

+
+.. code-block:: terminal
+
+    $ composer require symfony/message


This should be symfony/messenger conform the composer.json.

mhujer · 2018-03-23T12:24:52Z

components/message.rst

+libraries for now. You can use one of the following adapters:
+
+#. `PHP Enqueue bridge`_ to use one of their 10+ compatible queues such as
+   RabbitMq, Amazon SQS or Google Pub/Sub.


RabbitMq -> RabbitMQ

greg0ire · 2018-03-24T20:20:48Z

components/message.rst

+~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+To allow us to receive and send messages on the same bus and prevent a loop, the
+message bus is equipped with the ``WrapIntoReceivedMessage`` received. It will


I'm having a hard time parsing this sentence, especially the last word 😕 . Either it should be a noun, or it should be "the received/obtained WrapIntoReceivedMessage object"

greg0ire · 2018-03-24T20:23:24Z

components/message.rst

+A consumer is responsible for receiving messages from a source and dispatching
+them to the application.
+
+Let's say you already proceed some "orders" on your application using a


processed != proceed

"in" your application?

greg0ire · 2018-03-24T20:24:29Z

components/message.rst

+orders.
+
+You will read this CSV file and dispatch a ``NewOrder`` message. All you need to
+do is your custom CSV consumer and Symfony will do the rest.


"to do" => "to do is create your…" or "to write is your…"

consumer -> receiver?

greg0ire · 2018-03-24T20:25:58Z

components/message.rst

+
+    use App\Message\MyMessage;
+
+    $result = $this->get('message_bus')->handle(new MyMessage(/* ... */));


Maybe use DI to get the message_bus service?

Added an example of constructing it manually.

OskarStark · 2018-03-26T07:00:11Z

components/message.rst

+.. code-block:: xml
+
+    <service id="App\Handler\MyMessageHandler">
+       <tag name="message_handler" />


should be message.handler according to message.receiver here: https://github.com/symfony/symfony-docs/pull/9437/files#diff-f4526c4dad3a0bd7e76fd35201a182f2R276

OskarStark · 2018-03-26T07:00:27Z

components/message.rst

+       }
+    }
+
+.. code-block:: xml


you should add yaml config format, too

This has to be moved within the FrameworkBundle's documentation actually.

soyuka · 2018-03-26T08:42:16Z

components/message.rst

+.. code-block:: yaml
+
+    framework:
+       message:


messenger here and below

andreybolonin · 2018-03-26T08:59:11Z

components/message.rst

+Asynchronous messages
+~~~~~~~~~~~~~~~~~~~~~
+
+Using the Message Component is useful to decouple your application but it also


Using the Messenger Component

andreybolonin · 2018-03-26T08:59:44Z

components/message.rst

+Concepts
+--------
+
+.. image:: /_images/components/message/overview.png


image:: /_images/components/messenger/overview.png

andreybolonin · 2018-03-26T09:00:30Z

components/message.rst

+.. code-block:: yaml
+
+    framework:
+       message:


messenger:

andreybolonin · 2018-03-26T09:00:35Z

components/message.rst

+.. code-block:: yaml
+
+    framework:
+       message:


messenger:

soyuka · 2018-03-26T12:41:42Z

components/message.rst

+.. note::
+
+    If the message cannot be guessed from the handler's type-hint, use the
+    ``handles`` attribute on the tag.


I think best would be an example. Also mention that the guessing is done on the _invoke method argument

OskarStark · 2018-03-26T12:50:05Z

components/message.rst

+           arguments:
+               - "@serializer"
+               - "%new_orders_csv_file_path%"
+


please remove blank line here

sroze · 2018-03-27T14:21:49Z

Updated based on feedbacks, split the two documentations (i.e. as a "topic" and as a "component") and added more details. And Travis is green 🎉.

Can I have the honor of another round of reviews?

javiereguiluz · 2018-03-28T07:12:28Z

messenger.rst

+
+.. code-block:: xml
+
+    <service id="App\MessageHandler\MyMessageHandler">


To be consistent with other parts of Symfony, could we define an interface for Message Handlers so they can be autoconfigured?

This is proposed in the following PR: symfony/symfony#26685. Though, it's controversial :)

javiereguiluz · 2018-03-28T07:16:42Z

messenger.rst

+    {
+        public function indexAction(MessageBusInterface $bus)
+        {
+            $bus->dispatch(new MyMessage());


Could we use a more realistic example? Which is the simplest possible example where you can see the utility of messages and message bus? Also, can I store data inside a message class?

javiereguiluz · 2018-03-28T07:22:35Z

messenger.rst

+    framework:
+        messenger:
+            adapters:
+                default: "%env(MESSENGER_DSN)%"


Here the env var is called MESSENGER_DSN but below is AMQP_DSN

javiereguiluz · 2018-03-28T07:24:32Z

messenger.rst

+This is enough to allow you to route your message to the :code:`messenger.default_adapter`
+adapter. This will also configure the following for you:
+
+1. A :code:`messenger.default_sender` sender to be used when routing messages


This syntax:

:code:`...`

should be transformed to this:

``...``

in the whole article. Thanks!

javiereguiluz · 2018-03-28T07:26:55Z

messenger.rst

+            routing:
+                'My\Message\Message':  messenger.default_sender # Or another sender service name
+
+Such configuration would only route the ``MessageAboutDoingOperationalWork``


This paragraph mentions MessageAboutDoingOperationalWork ... but that's not used in the previous config example but in the next one.

javiereguiluz · 2018-03-28T08:50:40Z

components/messenger.rst

+The bus is used to dispatch messages. The behaviour of the bus is in its ordered
+middleware stack. The component comes with a set of middlewares that you can use.
+
+When using the message bus with Symfony's FrameworkBundle, the following middlewares


middleware is uncountable in English, so no plural for it :)

atailouloute · 2018-03-28T11:12:52Z

messenger.rst

+        }
+    }
+
+The :code:`YourAdaper` class need to implements the :code:`AdapterInterface`. It


I think here implements should be without s

yceruto · 2018-03-28T18:00:05Z

messenger.rst

+
+Instead of calling a handler, you have the option to route your message(s) to a
+sender. Part of an adapter, it is responsible of sending your message somewhere.
+You can configuration which message is routed to which sender with the following


typo configure?

sroze · 2018-03-29T08:12:44Z

Ready for another round of reviews 👍

boite

Partial review. Hope it helps.

boite · 2018-03-29T14:07:00Z

components/messenger.rst

+The Messenger Component
+=======================
+
+    The Messenger component helps applications send and receive messages to/from other applications or via message queues.


- The Messenger component helps applications send and receive messages to/from other applications or via message queues. + The Messenger component helps applications send messages to and receive messages from other applications and via message queues.

boite · 2018-03-29T14:11:51Z

components/messenger.rst

+.. image:: /_images/components/messenger/overview.png
+
+**Sender**:
+   Responsible for serializing and sending the message to _something_. This


- Responsible for serializing and sending the message to _something_. This + Responsible for serializing and sending messages to _something_. This

boite · 2018-03-29T14:13:14Z

components/messenger.rst

+   something can be a message broker or a third party API for example.
+
+**Receiver**:
+   Responsible for deserializing and forwarding the messages to handler(s). This


- Responsible for deserializing and forwarding the messages to handler(s). This + Responsible for deserializing and forwarding messages to handler(s). This

boite · 2018-03-29T14:16:32Z

components/messenger.rst

+
+**Handler**:
+   Given a received message, contains the user business logic related to the
+   message. In practice, that is just a PHP callable.


How about:-

Responsible for handling messages using the business logic applicable to the messages.

The part about PHP callable is confusing, explained better in the Handlers section, below and I think it should be omitted here.

boite · 2018-03-29T14:19:12Z

components/messenger.rst

+
+.. note:
+
+    Every middleware need to implement the ``MiddlewareInterface`` interface.


need -> needs
or
need to -> must

boite · 2018-03-29T14:23:11Z

components/messenger.rst

+Handlers
+--------
+
+Once dispatched to the bus, messages will be handled by a "message handler". A


"dispatched" is confusing here: according to the Bus section, the bus is responsible for dispatching messages; and the method used to get a message on to the bus is handle().

No, it's dispatch :)

boite · 2018-03-29T14:26:34Z

components/messenger.rst

+Once dispatched to the bus, messages will be handled by a "message handler". A
+message handler is a PHP callable (i.e. a function or an instance of a class)
+that will do the required processing for your message. It _might_ return a
+result::


It might return a result

What happens if it does or does not return a result? Does the following example code illustrate something about this statement?

boite · 2018-03-29T14:30:56Z

components/messenger.rst

+--------
+
+The communication with queuing system or third parties is delegated to
+libraries for now.


It isn't at all clear what this means or what are the implications for someone who intends to communicate with a queuing system or third party. Also system -> systems. And drop "for now" unless you want to say something about what will happen in the future.

Nyholm · 2018-03-29T18:42:19Z

components/messenger.rst

+       }
+    }
+
+Same bus received and sender


Capitalize.

Nyholm · 2018-03-29T18:43:50Z

messenger.rst

+        }
+    }
+
+Register your factory


yceruto · 2018-03-29T19:13:48Z

components/messenger.rst

+           $this->filePath = $filePath;
+       }
+
+       public function receive() : \Generator


iterable according to the interface?

That's compatible

boite

Good docs! Have managed to follow some and use the message bus and a message handler. :)

boite · 2018-03-29T17:36:52Z

messenger.rst

+
+    use Symfony\Bundle\FrameworkBundle\Controller\Controller;
+    use Symfony\Component\Messenger\MessageBusInterface;
+


Please add something like use App\Message\SendNotification; to make clear that SendNotification is not provided by the messenger component.

boite · 2018-03-29T17:39:03Z

messenger.rst

+Using the Messenger Service
+---------------------------
+
+Once enabled, the ``message_bus`` service can be injected in any service where


Will the following be enough to enable it?

# config/packages/framework.yml framework: messenger: ~

And what exactly is being enabled here - is it the message_bus service (as the sentence seems to indicate) or is it the Messenger Component?

boite · 2018-03-29T20:51:17Z

messenger.rst

+-------
+
+Instead of calling a handler, you have the option to route your message(s) to a
+sender. Part of an adapter, it is responsible of sending your message somewhere.


of sending -> for sending

boite · 2018-03-29T20:56:33Z

messenger.rst

+                'My\Message\Message':  messenger.default_sender # Or another sender service name
+
+Such configuration would only route the ``My\Message\Message`` message to be
+asynchronous, the rest of the messages would still be directly handled.


Instead of two sentences, one before the config example and one after, how about just one:-

"The following configuration shows how you can route a class of messages to a sender, leaving other classes of messages to be passed to their respective handlers."

Also, routing to messenger.default_sender seems to be wrong:-

In CheckExceptionOnInvalidReferenceBehaviorPass.php line 32: [Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException] The service "messenger.asynchronous.middleware.send_message_to_producer" ha s a dependency on a non-existent service "messenger.default_sender".

It should be messenger.sender.default.

It's less clear with a single example IMHO. I've updated the sender configuration 👍

boite · 2018-03-29T20:58:48Z

messenger.rst

+        messenger:
+            routing:
+                'My\Message\MessageAboutDoingOperationalWork': messenger.operations_sender
+                '*': messenger.default_sender


"You can route all classes of message to a sender using an asterisk instead of a class name:"

Yep, nice call. Updated 👍

boite · 2018-03-29T21:16:34Z

messenger.rst

+Registering your middleware
+---------------------------
+
+The message bus is based on a set of middleware. If you are un-familiar with the concept,


un-familiar -> unfamiliar

boite · 2018-03-29T21:17:31Z

messenger.rst

+
+.. code-block:: xml
+
+    <service id="Your\Own\Middleware">


How about App\Middleware.

boite · 2018-03-29T21:18:42Z

messenger.rst

+Your own Adapters
+-----------------
+
+Learn how to build your own adapters within the Component's documentation. Once


Learn how to build your own adapters within the Component's documentation.

It is unclear what is meant by this!

boite · 2018-03-29T21:19:33Z

messenger.rst

+
+Learn how to build your own adapters within the Component's documentation. Once
+you have built your classes, you can register your adapter factory to be able to
+use it via a DSN in the Symfony application.


Where can I read about how to do this?

In the "Use your adapter" section :)

boite · 2018-03-29T21:20:55Z

messenger.rst

+    }
+
+The ``YourAdaper`` class need to implement the ``AdapterInterface``. It
+will like the following example::


need -> needs

or

need to -> must

and

It will be like

or

It will look like

theofidry · 2018-03-30T08:07:21Z

components/messenger.rst

+
+**Sender**:
+   Responsible for serializing and sending the message to _something_. This
+   something can be a message broker or a third party API for example.


a messager handler, broker or a third-party API.

Reasons:

The current phrasing kinda implies the component is very queue oriented. It's not wrong but it's not limited to this use case

Using it with a message handler is a case common enough to be mentioned IMO

I'm not sure all the people are familiar with queues and its related vocabulary so putting message handler which is likely to be more commonly known will make it more accessible

theofidry · 2018-03-30T08:12:33Z

components/messenger.rst

+--------
+
+Once dispatched to the bus, messages will be handled by a "message handler". A
+message handler is a PHP callable (i.e. a function or an instance of a class)


we could add a link to the official doc here:

callable: https://secure.php.net/manual/en/language.types.callable.php

anonymous function: https://secure.php.net/manual/en/functions.anonymous.php

an invokable class: https://secure.php.net/manual/en/language.oop5.magic.php#object.invoke

This PR was merged into the 4.1-dev branch. Discussion ---------- [Messenger] Rename the middleware tag | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ø | License | MIT | Doc PR | symfony/symfony-docs#9437 After a using it for a bit of time, it's weird to have the `messenger.message_handler` tag while using the `message_bus_middleware` tag for the middlewares. I propose to rename the tag from `message_bus_middleware` to `messenger.bus_middleware` to keep some consistency. Commits ------- dd18445 Rename the middleware tag from `message_bus_middleware` to `messenger.bus_middleware`

boite · 2018-04-12T12:45:34Z

messenger.rst

+adapter. This will also configure the following for you:
+
+1. A ``messenger.default_sender`` sender to be used when routing messages
+2. A ``messenger.default_receiver`` receiver to be used when consuming messages.


These should be messenger.sender.default and messenger.receiver.default (there are numerous occurrences that need to be changed).

sroze · 2018-04-12T20:36:33Z

It's ready to be merged. Tweaks can follow in other PRs I suppose.

boite · 2018-04-13T09:20:39Z

messenger.rst

+                'My\Message\MessageAboutDoingOperationalWork': another_adapter
+                '*': amqp
+
+A class of message can also be routed to a multiple senders by specifying a list:


- A class of message can also be routed to a multiple senders by specifying a list: + A class of message can also be routed to multiple senders by specifying a list:

sroze · 2018-04-15T21:15:06Z

@boite thank you very much for all your reviews, much appreciated! I've updated the wording of the sentence you highlighted in your last review.

boite · 2018-04-16T15:02:36Z

Well done @sroze; this all looks good.

javiereguiluz · 2018-04-16T15:28:12Z

Let's merge this because, otherwise, this would be one of those eternal pull requests that never get merged. We can improve contents later as needed. Thanks Samuel for your contribution and thanks to the community for the reviews!

…guiluz, wiese) This PR was merged into the master branch. Discussion ---------- Symfony Messenger component documentation This pull-request adds some documentation for the Messenger component. As it is, it's extracted from the README built incrementally in the code pull-request. I'm sure there will be lots to change when the implementation is merged :) Commits ------- c5306b8 Minor wording change 32403ea Update the documentation to reflect the latest changes 3fb973c Update based on comments 509e149 Add a documentation about middlewares and update based on reviews fb88abc Add Messenger in the topics a15752b Fix unresolved reference 25c0b6e It helps multiple applications Please enter the commit message for your changes. Lines starting bcfae23 Finish the documentation about the custom adapter 2493c90 Update typos and missing reference 31a56ee Uses `::` to display as code blocks 5c828e4 Update the documentation a bit, and add more FrameworkBundle documentation 88ba8fe Merge pull request #1 from wiese/patch-3 b26de80 minor doc fixes for the Message component b40bc71 Fixed the RST syntax issues 585491d Move the documentation from the main PR to RST format.

Move the documentation from the main PR to RST format.

585491d

carsonbot added the Status: Needs Review label Mar 14, 2018

sroze added a commit to sroze/symfony that referenced this pull request Mar 14, 2018

Remove the documentation from the code repository (moved to symfony/s…

9d8b744

…ymfony-docs#9437)

sroze mentioned this pull request Mar 14, 2018

[Messenger] Add a new Messenger component symfony/symfony#24411

Closed

javiereguiluz added the Waiting Code Merge Docs for features pending to be merged label Mar 14, 2018

Fixed the RST syntax issues

b40bc71

sroze added a commit to sroze/symfony that referenced this pull request Mar 19, 2018

Remove the documentation from the code repository (moved to symfony/s…

f1f6e85

…ymfony-docs#9437)

javiereguiluz removed the Waiting Code Merge Docs for features pending to be merged label Mar 23, 2018

javiereguiluz changed the title ~~Symfony Message component documentation~~ Symfony Messenger component documentation Mar 23, 2018

wiese and others added 2 commits March 23, 2018 11:22

minor doc fixes for the Message component

b26de80

Merge pull request #1 from wiese/patch-3

88ba8fe

minor doc fixes for the Message component

javiereguiluz reviewed Mar 23, 2018

View reviewed changes

cafferata reviewed Mar 23, 2018

View reviewed changes

javiereguiluz mentioned this pull request Mar 23, 2018

Added the Messenger component symfony/marketing#457

Merged

mhujer reviewed Mar 23, 2018

View reviewed changes

Guite mentioned this pull request Mar 23, 2018

Symfony 4 and 5 Guite/MostGenerator#1068

Closed

greg0ire reviewed Mar 24, 2018

View reviewed changes

OskarStark requested changes Mar 26, 2018

View reviewed changes

soyuka reviewed Mar 26, 2018

View reviewed changes

andreybolonin reviewed Mar 26, 2018

View reviewed changes

soyuka reviewed Mar 26, 2018

View reviewed changes

OskarStark reviewed Mar 26, 2018

View reviewed changes

components/message.rst Outdated

arguments:

- "@serializer"

- "%new_orders_csv_file_path%"

Copy link

Contributor

OskarStark Mar 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove blank line here

sroze added 2 commits March 27, 2018 14:58

Add Messenger in the topics

fb88abc

Add a documentation about middlewares and update based on reviews

509e149

javiereguiluz reviewed Mar 28, 2018

View reviewed changes

atailouloute reviewed Mar 28, 2018

View reviewed changes

yceruto reviewed Mar 28, 2018

View reviewed changes

Update based on comments

3fb973c

boite suggested changes Mar 29, 2018

View reviewed changes

Nyholm reviewed Mar 29, 2018

View reviewed changes

yceruto reviewed Mar 29, 2018

View reviewed changes

boite suggested changes Mar 29, 2018

View reviewed changes

theofidry reviewed Mar 30, 2018

View reviewed changes

sroze mentioned this pull request Apr 8, 2018

[Messenger] Rename the middleware tag symfony/symfony#26862

Merged

boite reviewed Apr 12, 2018

View reviewed changes

Update the documentation to reflect the latest changes

32403ea

soyuka approved these changes Apr 13, 2018

View reviewed changes

boite reviewed Apr 13, 2018

View reviewed changes

Minor wording change

c5306b8

javiereguiluz added Status: Reviewed and removed Status: Needs Review labels Apr 16, 2018

javiereguiluz added this to the 4.1 milestone Apr 16, 2018

javiereguiluz added the Messenger label Apr 16, 2018

javiereguiluz merged commit c5306b8 into symfony:master Apr 16, 2018


		$ composer require symfony/message

		Alternatively, you can clone the `<https://github.com/symfony/message>`_ repository.


		use App\Message\MyMessage;

		$result = $this->get('message_bus')->handle(new MyMessage(/* ... */));


		.. code-block:: xml

		<service id="App\MessageHandler\MyMessageHandler">


		.. note:

		Every middleware need to implement the ``MiddlewareInterface`` interface.


		use Symfony\Bundle\FrameworkBundle\Controller\Controller;
		use Symfony\Component\Messenger\MessageBusInterface;

Symfony Messenger component documentation #9437

Symfony Messenger component documentation #9437

Conversation

sroze commented Mar 14, 2018 • edited Loading

fabpot commented Mar 23, 2018

sroze commented Mar 23, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

greg0ire Mar 24, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

greg0ire Mar 24, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andreybolonin Mar 26, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andreybolonin Mar 26, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andreybolonin Mar 26, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andreybolonin Mar 26, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sroze commented Mar 27, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sroze commented Mar 29, 2018

boite left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yceruto Mar 29, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

boite left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sroze commented Mar 14, 2018 •

edited

Loading

greg0ire Mar 24, 2018 •

edited

Loading

greg0ire Mar 24, 2018 •

edited

Loading

andreybolonin Mar 26, 2018 •

edited

Loading

andreybolonin Mar 26, 2018 •

edited

Loading

andreybolonin Mar 26, 2018 •

edited

Loading

andreybolonin Mar 26, 2018 •

edited

Loading

yceruto Mar 29, 2018 •

edited

Loading

boite Apr 12, 2018 •

edited

Loading