Skip to content

add the new inlined routing configuration example #9559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

zairigimad
Copy link
Contributor

making an example of the new feature in the routing component.

@javiereguiluz
Copy link
Member

Not sure if we need another example because we already explain the inlined requirements and default values. See #9520 But let's wait and read other opinions. Thanks!

@wouterj
Copy link
Member

wouterj commented May 5, 2018

Yeah, I don't think we should update all routing examples to use the new inlined syntax (tbh, I don't think it's that clear if you're new). So unless the inline syntax will become the official standard, I would vote to only documented in the section added by #9520 .

This however doesn't mean I don't like your contributions @zairigimad. Thanks a lot for proposing improvements to the docs!

@javiereguiluz
Copy link
Member

Let's close this for now in favor of #9520 ... and we'll revisit this decision in the future when people are more used to the new syntax. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants