[Form] Fixed ChoiceType trim option #9598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Apr 16, 2018
This PR was merged into the 2.7 branch. Discussion ---------- [Form] Fixed trimming choice values | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24247, #24712 | License | MIT | Doc PR | symfony/symfony-docs#9598 Follows #24712 discussion. Commits ------- 00cdf5e [Form] Fixed trimming choice values
|
Thank you for the rewording 👍 |
xabbuh
requested changes
Apr 20, 2018
reference/forms/types/choice.rst
Outdated
| @@ -323,6 +324,14 @@ error_bubbling | |||
| Set that error on this field must be attached to the field instead of | |||
| the parent field (the form in most cases). | |||
|
|
|||
| trim | |||
| ~~~~ | |||
There was a problem hiding this comment.
I think we should move the description to its own file to be able to reuse it in other form types. This is currently missing in some documents (see the failing build).
xabbuh
reviewed
May 7, 2018
reference/forms/types/choice.rst
Outdated
| @@ -30,6 +30,7 @@ To use this field, you must specify *either* ``choices`` or ``choice_loader`` op | |||
| | Overridden | - `compound`_ | | |||
| | options | - `empty_data`_ | | |||
| | | - `error_bubbling`_ | | |||
| | | - `choice_type_trim`_ | | |||
There was a problem hiding this comment.
here we would still have to use trim
There was a problem hiding this comment.
Was not sure ^^. Fixed, thanks!
xabbuh
reviewed
May 7, 2018
| **type**: ``boolean`` **default**: ``false`` | ||
|
|
||
| Trimming is disabled by default because the selected value or values must match | ||
| the given choice values exactly (and they could contain white spaces). |
There was a problem hiding this comment.
"whitespaces" (without the space)?
There was a problem hiding this comment.
Agreed, fixed. Thanks again!
xabbuh
approved these changes
May 7, 2018
|
Thanks Jules. |
wouterj
added a commit
that referenced
this pull request
May 8, 2018
…uiluz) This PR was merged into the 2.7 branch. Discussion ---------- [Form] Fixed ChoiceType trim option Ref symfony/symfony#26932. Commits ------- 2dd6c56 fixup typo 360066d fixup option links 6631665 fixup @xabbuh's comment proper choice type trim file 8bfa059 Reword bbca3b0 [Form] Fixed ChoiceType trim option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref symfony/symfony#26932.