Update typescript.rst #9827
Closed
Update typescript.rst #9827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`configFileName` was renamed in `configFile`
|
@kallard1 good catch! This is correct according to https://github.com/TypeStrong/ts-loader/blob/master/README.md#configfile-string-defaulttsconfigjson so let's merge it (on 3.4 branch, the oldest maintained branch that contains this bug ... we'll merge it in the other branches automatically). Also, congrats on your first Symfony contribution! |
javiereguiluz
added a commit
that referenced
this pull request
May 27, 2018
This PR was submitted for the 4.0 branch but it was merged into the 3.4 branch instead (closes #9827). Discussion ---------- Update typescript.rst `configFileName` was renamed in `configFile` for Typescript configuration ``` Module build failed: Error: ts-loader was supplied with an unexpected loader option: configFileName Please take a look at the options you are supplying; the following are valid options: silent / logLevel / logInfoToStdOut / instance / compiler / context / configFile / transpileOnly / ignoreDiagnostics / errorFormatter / colors / compilerOptions / appendTsSuffixTo / appendTsxSuffixTo / onlyCompileBundledFiles / happyPackMode / getCustomTransformers / reportFiles / experimentalWatchApi / allowTsInNodeModules ``` Commits ------- e2cf45c Update typescript.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configFileNamewas renamed inconfigFilefor Typescript configuration