Document BC Break introduced in commit 741859dc #989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMO, the doc for the master branch should be refactored to reflect the fact that the method is not needed anymore instead of just adding a note. Keeping the reference to the old method in the doc would simply be confusing |
|
@stof then I think there is no need about mentioning it at all, as docs says to implement only |
|
well, the doc for 2.1 should mention the EquatableInterface |
weaverryan
added a commit
that referenced
this pull request
Jan 22, 2012
Document BC Break introduced in commit 741859dc
|
Hi guys! I've merged this in, but then changed it to have a different tone in sha: 93a575a My thought is that most people won't care about the new Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add info to book and cookbook about BC break in
UserInterface