Link to proxy configuration docs from the routing scheme page #9924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiofdsantos
approved these changes
Jun 15, 2018
maxhelias
approved these changes
Jun 15, 2018
javiereguiluz
approved these changes
Jun 18, 2018
There was a problem hiding this comment.
@colinodell I like your contribution, but I reworded it slightly to make it look less like a Symfony problem and more like a user/config problem. Thanks!
xabbuh
reviewed
Jun 18, 2018
| Forcing HTTPS while using a reverse proxy or load balancer requires a proper | ||
| configuration to avoid infinite redirect loops; see :doc:`/deployment/proxies` | ||
| for more details. | ||
|
|
There was a problem hiding this comment.
this blank line should be removed, but we can do that while merging
xabbuh
reviewed
Jun 18, 2018
| .. note:: | ||
|
|
||
| Forcing HTTPS while using a reverse proxy or load balancer requires a proper | ||
| configuration to avoid infinite redirect loops; see :doc:`/deployment/proxies` |
There was a problem hiding this comment.
Chrome uses "redirect loop" in its error message:
xabbuh
approved these changes
Jun 18, 2018
|
Thanks @javiereguiluz! 👍 |
|
Thanks Colin! This is now merged (in 2.8, which is now the oldest maintained branch) |
javiereguiluz
added a commit
that referenced
this pull request
Jun 18, 2018
…page (colinodell, javiereguiluz) This PR was submitted for the 2.7 branch but it was merged into the 2.8 branch instead (closes #9924). Discussion ---------- Link to proxy configuration docs from the routing scheme page This should help developers avoid infinite redirect loops. See symfony/symfony#27603 Commits ------- 671e13c Reword and added a note c717e75 Link to proxy configuration docs from the routing scheme page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help developers avoid infinite redirect loops.
See symfony/symfony#27603