Removed a short article about overriding bundle templates #9936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeahDude
reviewed
Jun 19, 2018
templating.rst
Outdated
| by placing a template of the same name in the ``templates/bundles/AcmeBlogBundle/`` | ||
| directory. This gives the power to override templates from any vendor bundle. | ||
| Using this namespaced syntax instead of their real file paths to refer to bundle | ||
| templates is part of the bundle overriding mechanism. This allows applications |
There was a problem hiding this comment.
This part is not exact, but do we care? bundle overriding mechanism => Twig overriding mechanism
There was a problem hiding this comment.
You are right! I've reworded it.
javiereguiluz
added a commit
that referenced
this pull request
Jun 20, 2018
… (javiereguiluz) This PR was squashed before being merged into the 4.0 branch (closes #9936). Discussion ---------- Removed a short article about overriding bundle templates Spotted while fixing #9923. @stof I have a question for you. I left this caution but I don't know if it's still needed: ```rst .. caution:: If you add a template in a new location, you *may* need to clear your cache (``php bin/console cache:clear``), even if you are in debug mode. ``` I tested in a Symfony 4 app. If I add a new template in my app, there's no need to clear the cache in `dev`. Does this caution only applies when adding new templates to override bundles? Or is it something no longer relevant in Symfony 4? Thanks! Commits ------- 44a33a4 Removed a short article about overriding bundle templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted while fixing #9923.
@stof I have a question for you. I left this caution but I don't know if it's still needed:
I tested in a Symfony 4 app. If I add a new template in my app, there's no need to clear the cache in
dev. Does this caution only applies when adding new templates to override bundles? Or is it something no longer relevant in Symfony 4? Thanks!