[Routing] do not install SensioFrameworkExtraBundle #9983
Conversation
The routing annotations of SensioFrameworkExtraBundle are deprecate since sensiolabs/SensioFrameworkExtraBundle#562 Also the example code in this documentation does not use SensioFrameworkExtraBundle at all but the core annotation as it should be. So installing the SensioFrameworkExtraBundle is pointless.
| @@ -20,12 +20,6 @@ the change is simple. | |||
| Creating Routes | |||
| --------------- | |||
|
|
|||
| First, add support for annotations via the SensioFrameworkExtraBundle: | |||
There was a problem hiding this comment.
This is still a requirement unless one need only routing annotation and should then depend on doctrine annotation or doctrine common as this bundle does.
We should adapt the note but we cannot remove it.
There was a problem hiding this comment.
This page is about routing. So why exactly is this still a requirement for routing?
There was a problem hiding this comment.
Because the routing component or the basic skeleton don't rely on doctrine annotations by default.
There was a problem hiding this comment.
I've reworded as requested by @HeahDude. Also, we don't use Flex shortcuts in the docs to make everything explicit, but we could make an exception in this case with composer require annotations
There was a problem hiding this comment.
I'm 👍 for the exception here. Thanks!
There was a problem hiding this comment.
Why don't we require doctrine/annotations here instead?
There was a problem hiding this comment.
Although that be technically correct ... it's confusing for readers. We're in the routing chapter, one of the essential and critical chapters of the docs. It's already confusing to tell them to install annotations (because that basic feature should always be included and available in Symfony). If we tell them to install doctrine/annotations ... there will be a WTF moment. doctrine? What's this? And some people will think it's a doc error 😢
This PR was squashed before being merged into the 5.2.x-dev branch (closes #577). Discussion ---------- Update routing annotations doc as deprecated Fixes #568 together with symfony/symfony-docs#9983 Commits ------- b5a4237 Update routing annotations doc as deprecated
|
It's merged now! thank you all for the discussion. |
…on, javiereguiluz) This PR was merged into the 4.0 branch. Discussion ---------- [Routing] do not install SensioFrameworkExtraBundle The routing annotations of SensioFrameworkExtraBundle are deprecate since sensiolabs/SensioFrameworkExtraBundle#562 Also the example code in this documentation does not use SensioFrameworkExtraBundle at all but the core annotation as it should be. So installing the SensioFrameworkExtraBundle is pointless. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- c98babf Reword 6119b67 [Routing] do not install SensioFrameworkExtraBundle
The routing annotations of SensioFrameworkExtraBundle are deprecate since sensiolabs/SensioFrameworkExtraBundle#562
Also the example code in this documentation does not use SensioFrameworkExtraBundle at all but the core annotation as it should be. So installing the SensioFrameworkExtraBundle is pointless.