[Cache] add Redis options compression and tcp_keepalive #9985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeahDude
approved these changes
Jul 1, 2018
greg0ire
reviewed
Jul 2, 2018
| @@ -128,6 +134,10 @@ Available Options | |||
| Specifies the delay (in milliseconds) between reconnection attempts in case the client | |||
| loses connection with the server. | |||
|
|
|||
| ``tcp_keealive`` (type: ``int``, default: ``0``) | |||
There was a problem hiding this comment.
And in the commit message :P
| @@ -128,6 +134,10 @@ Available Options | |||
| Specifies the delay (in milliseconds) between reconnection attempts in case the client | |||
| loses connection with the server. | |||
|
|
|||
| ``tcp_keealive`` (type: ``int``, default: ``0``) | |||
| Specifies the TCP-keepalive timeout of the connection. This requires phpredis v4 or | |||
There was a problem hiding this comment.
I guess the timeout is in seconds, but we should specify it. Thanks!
Specifies `TCP keepalive`_ timeout of the connection in seconds. This requires phpredis v4 or higher and a TCP-keepalive enabled server.
.. _`TCP keepalive`: https://en.wikipedia.org/wiki/Keepalive|
updated thanks :) |
greg0ire
approved these changes
Jul 3, 2018
|
Thank you Nicolas. |
javiereguiluz
added a commit
that referenced
this pull request
Jul 6, 2018
…nicolas-grekas) This PR was merged into the master branch. Discussion ---------- [Cache] add Redis options compression and tcp_keepalive Since symfony/symfony#27646 Commits ------- 266020c [Cache] add Redis options compression and tcp_keepalive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since symfony/symfony#27646