Skip to content
This repository was archived by the owner on Nov 27, 2020. It is now read-only.

Sort Composer packages automatically #1036

Closed
wants to merge 2 commits into from
Closed

Sort Composer packages automatically #1036

wants to merge 2 commits into from

Conversation

javiereguiluz
Copy link
Member

@javiereguiluz javiereguiluz commented Dec 28, 2016 •
edited
Loading

I do this in all my projects and Laravel added this too recently (laravel/framework#16843) but I don't know if others will agree 😄

@bocharsky-bw
Copy link
Contributor

In this case, I think you have to reorder existing packages as well in this PR.

@javiereguiluz javiereguiluz mentioned this pull request Dec 29, 2016
Merged
@HeahDude
Copy link

👍

@bocharsky-bw bocharsky-bw mentioned this pull request Dec 30, 2016
Merged
javiereguiluz added a commit to symfony/demo that referenced this pull request Dec 30, 2016
@javiereguiluz
minor #416 Sort new Composer packages automatically (bocharsky-bw)
a580b8b 
This PR was merged into the master branch.

Discussion
----------

Sort new Composer packages automatically

Related to the symfony/symfony-standard#1036

However, I think it makes even more sense here since we have already sorted packages in composer.json.

Commits
-------

749a394 Sort new Composer packages automatically
javiereguiluz added a commit to EasyCorp/EasyAdminBundle that referenced this pull request Dec 30, 2016
@javiereguiluz
minor #1454 Sort Composer packages automatically (javiereguiluz)
0665717 
This PR was merged into the master branch.

Discussion
----------

Sort Composer packages automatically

Same minor change as proposed in symfony/symfony-standard#1036

Commits
-------

88ce670 Sort Composer packages automatically
@dunglas
Copy link
Member

dunglas commented Jan 10, 2017

👍

@bocharsky-bw
Copy link
Contributor

bocharsky-bw commented Jan 17, 2017 •
edited
Loading

What about to sort alphabetically registered bundles in AppKernel.php in addition to this suggestion?
P.S. I'm not sure this idea worth to be opened in another issue.

@lyrixx
Copy link
Member

lyrixx commented Jan 17, 2017

👍

@fabpot
Copy link
Member

fabpot commented Feb 24, 2017

How does that work? I've just added this config to my composer.json, but running composer install or composer update does not sort my composer.json deps.

@chalasr
Copy link
Member

chalasr commented Feb 24, 2017

@fabpot indeed, running install or update doesn't seem to trigger it but require does.

@fabpot
Copy link
Member

fabpot commented Feb 24, 2017

@chalasr Ok, sounds a bit counter-intuitive. I would have expected update to reorder my deps as well.

@chalasr
Copy link
Member

chalasr commented Feb 24, 2017

I agree, that could deserve a PR on composer.

@stof
Copy link
Member

stof commented Feb 24, 2017

@fabpot composer update is not allowed to alter the composer.json file (and composer install is not even allowed to alter the lock file)

@fabpot
Copy link
Member

fabpot commented Feb 24, 2017

I've done that as of 2.7 and merged everything up.

@fabpot fabpot closed this Feb 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@javiereguiluz @bocharsky-bw @HeahDude @dunglas @lyrixx @fabpot @chalasr @stof