This repository was archived by the owner on Nov 27, 2020. It is now read-only.
added support for the new @required annotation #1052
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In fact, "Required" is already listed, so maybe we can recommend that while we suggest doctrine to accept the "required" variant? |
|
I think using |
|
Closing in favor of #21837 (whatever the solution there, we will get rid of the autoload file here) |
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Mar 15, 2017
…oader and `@required` (nicolas-grekas) This PR was merged into the 3.3-dev branch. Discussion ---------- [FrameworkBundle] Lazy configuration of annotations' loader and `@required` | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This would remove the need for symfony/symfony-standard#1052 and for the `autoload.php` file altogether. Tested on symfony-demo with great success so far. Commits ------- d332b37 [FrameworkBundle] Lazy configuration of annotations' loader and `@required`
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Mar 15, 2017
…oader and `@required` (nicolas-grekas) This PR was merged into the 3.3-dev branch. Discussion ---------- [FrameworkBundle] Lazy configuration of annotations' loader and `@required` | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This would remove the need for symfony/symfony-standard#1052 and for the `autoload.php` file altogether. Tested on symfony-demo with great success so far. Commits ------- d332b37b4b [FrameworkBundle] Lazy configuration of annotations' loader and `@required`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for symfony/symfony#21763