Remove app/autoload.php #1056
Remove app/autoload.php #1056
Conversation
|
I'm 👍 with these changes, but why don't we also recommend a custom PHPUnit bootstrap file? On every project on which I have to write PHPUnit tests, I have to create a custom booststrap file to reset the database or to change some stuff before testing. What do you think? |
|
I'm a newcomer so may be misinterpreting but everything I've saw recently seemed to have been about moving Symfony towards a more minimal, lean structure by default while allowing expansion if required (see slight glimpses of Flex and the reimagining of symfony-standard. Adding a file whose sole contents will be something like Anecdotally I haven't needed to create a PHPUnit bootstrap for any of the Symfony projects I've worked on recently - LiipFunctionalTestBundle has taken care of all my DB resetting needs. |
|
If I'm not mistaken 'app/autoload.php' is used to load classes or file functions no composerify for the project |
|
@flug The goal of this PR is just to remove Symfony Standard's autoload file that becomes useless thanks to symfony/symfony#21837, not to get rid of the ClassLoader component (which will be removed in Symfony 4.0 only) |
Now that symfony/symfony#21837 and sensiolabs/SensioDistributionBundle#313 are merged, app/autoload.php can be removed and replaced with the standard Composer autoloader.
|
sensiolabs/SensioDistributionBundle#313 is merged, and this PR has been updated to use the latest version of SensioDistributionBundle. This is now good to go. The fabbot check failure is unrelated to this change. |
|
Thank you @BPScott. |
This PR was merged into the 3.3-dev branch. Discussion ---------- Remove app/autoload.php Now that symfony/symfony#21837 is merged, app/autoload.php can be removed and replaced with the standard Composer autoloader. ~WAIT! This can't be merged *just* yet, as it throws errors when running the `buildBootstrap` post install/update script. The fix for this is in sensiolabs/SensioDistributionBundle#313. That PR must be merged and this PR must be updated to use a version of SensioDistributionBundle that contains the fix before this is good to go.~ EDIT: sensiolabs/SensioDistributionBundle#313 is merged (as of 24/04), and this PR has been updated to use the latest version of SensioDistributionBundle. This is now good to merge Commits ------- 298f8b2 Remove app/autoload.php
Now that symfony/symfony#21837 is merged, app/autoload.php can be removed and replaced with the standard Composer autoloader.
WAIT! This can't be merged just yet, as it throws errors when running thebuildBootstrappost install/update script. The fix for this is in sensiolabs/SensioDistributionBundle#313. That PR must be merged and this PR must be updated to use a version of SensioDistributionBundle that contains the fix before this is good to go.EDIT: sensiolabs/SensioDistributionBundle#313 is merged (as of 24/04), and this PR has been updated to use the latest version of SensioDistributionBundle. This is now good to merge