This repository was archived by the owner on Nov 27, 2020. It is now read-only.
Show console log channel so that command runs with error code are visible #1107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing as outdated. Please open against https://github.com/symfony/recipes if you still think this is required. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that the change introduced in #1044 not such a clear cut case, just spent a lot of time finding why it is not shown any more. With the exception/error case I agree, that the log statement is superfluous, but that is not the case for error codes.
Imagine a command which signals success/failure by return codes (as is usual in CLI), then when you run it, you have no visible feedback on whether it was run successfully or not:
with the logging for console not filtered out it would be much more user friendly:
which is I think exactly the reason why the printing out logs in console feature was introduced.
To sum it up, I think not showing the logs in the error code case is more developer unfriendly than them being showed when not needed.
cc @chalasr