Skip to content
This repository was archived by the owner on Nov 27, 2020. It is now read-only.

Conversation

bamarni
Copy link
Contributor

@bamarni bamarni commented May 14, 2013

...#535)

@stof
Copy link
Member

stof commented May 15, 2013

symfony-standard is the base for your projects. suggest does not make sense in projects (either the project uses the dependency or it does not, there is no optional stuff)

@bamarni
Copy link
Contributor Author

bamarni commented May 15, 2013

Before being a base project it's a package, so imo it's fine to have a suggest section, if I follow your reasonment then the description is wrong, shouldn't it be "A Symfony Project?" :)

In both situations what doesn't make sense is to keep this on final products, not to have it on the base package.

@stof
Copy link
Member

stof commented May 15, 2013

suggests are displayed when installing deps. symfony-standard will never be installed as a dependency, so these suggestions will not be displayed

@bamarni
Copy link
Contributor Author

bamarni commented May 15, 2013

let's say they'd just be displayed differently (in an IDE instead of a console).

@fabpot
Copy link
Member

fabpot commented May 15, 2013

We have removed those bundles because of their license.. does not make sense to me to suggest installing them.

@fabpot fabpot closed this May 15, 2013
@kriswallsmith
Copy link
Contributor

In principle, keeping the license as low as possible makes sense. In reality, the vast majority of projects created based on this distribution will be licensed proprietary and be able to use bundles with other licenses (caveat: I'm no lawyer). I am in favor of suggesting these two bundles and adding (Apache license) to their descriptions. It is more friendly and (dare I suggest) more 🇫🇷

As far as when suggested packages are displayed, it would be nice if Composer's create-project command did this.

@fabpot
Copy link
Member

fabpot commented Jun 14, 2013

I think we need to have a discussion about which bundles to include anyway. Like the REST bundle, or the other important bundles. ping @lsmith77

@kriswallsmith
Copy link
Contributor

I'm a big fan of contextual configuration, which annotations provide.

@lsmith77
Copy link
Contributor

btw .. while FOSRestBundle can work with the core serializer most people use it with JMSSerializerBundle which in turn due to some unfortunately dep pulls in pretty much every single line of code @schmittjoh has ever written:
schmittjoh/JMSSerializerBundle#294

@schmittjoh
Copy link
Contributor

@lsmith77 I agree with the deps, but I guess the amount of lines does not really matter in the end if there must not be a single line of non-MIT code.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants