[BUG] or seems to me #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it, if i have a marking and a transition with data this doesn't work. And , this seems logical because as it, the marking should have all froms for its wanted transition. I think this is a bug but maybe it is a design's choice or other thing.
If it's a bug, i redraw this pull request by tests, clear explinations and a reformated issue.
```yaml
Workflow.php on line 290:
Marking {symfony#6
-places: array:1 [▼
"initial" => 1
]
}
Workflow.php on line 290:
array:1 [▼
0 => Transition {#548 ▼
-name: "go_search"
-froms: array:3 [▼
0 => "initial"
1 => "vehicles"
2 => "informations"
]
-tos: array:1 [▼
0 => "search"
]
}
]
```
|
You should send Pull Requests in the main Symfony repository. |
|
Thanks for contributing this pull request. However, the repositories of individual Symfony Components are read-only, so pull requests are ignored. Please, submit this pull request to the main Symfony repository at https://github.com/symfony/symfony/pulls Thank you! |
|
ping @lyrixx can you please have a look at this PR and borrow on symfony/symfony if it makes sense? |
|
Ah, I missed this PR. (Site note: @nicolas-grekas we really a need a bot to auto-close PR with a very good explaination message ;)) So basically, this not a bug fix. I invite you to read this comment |
we have a prototype since yesterday, should come alive soon :) |
symfony-splitter
pushed a commit
that referenced
this pull request
Aug 12, 2025
* 7.4: [ObjectMapper] do not require mapping a target's required promoted property when not on source (#2) run tests with PHPUnit 12.3 [GitHub] Update .github/PULL_REQUEST_TEMPLATE.md to remove SF 7.2 as it's not supported anymore [CI] fixed the Intl data tests actions Tests fails due to unknown option -v which is shorthand of the --verbose as per the phpunit its removed without any replacement sebastianbergmann/phpunit#5647 (comment) [Mailer] Fix expected exception message to include quotes around "http(s)://" [WebProfilerBundle] Fix toolbar not rendering after replacing it [Validator] (60455) Validate translations for Arabic (ar) (60474) Remove translation state attribute for Twig template validator in Ukrainian translation [VarDumper] Fix dumping objects from the DOM extension [Mailer] Add MicrosoftGraph API Transport [Yaml] Fix code style [Tests] Adapt testAddHtmlContentWithErrors to be HTML5 compliant Add friendly name in the `to` field [ObjectMapper] read source metadata before transform [HtmlSanitizer] Fix force_attributes not replacing existing attribute in initial data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it, if i have a marking and a transition with the following data this continue without validate the transition. And , this seems logical because as it, the marking should have all froms for its wanted transition. I think this is a bug but maybe it is a thing that i don't tested in a good way.
If it's a bug, i redraw this pull request by tests, clear explinations and a reformated issue.