Skip to content

Fix bug : dump float value in a context where locale sets comma as separator instead of dot #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix bug : dump float value in a context where locale sets comma as separator instead of dot #2

wants to merge 2 commits into from

Conversation

romainneutron
Copy link
Contributor

For example, if LC_ALL is set to fr_FR then float number got ',' as separator ; example : 4,75

In order to follow Yaml Specifications (http://yaml.org/type/float.html) we must replace the comma with a dot, and specify the float type.

Code to reproduce the bug :

<?php
setlocale(LC_ALL, 'fr_FR.UTF-8', 'fr_FR.UTF8', 'fr_FR.utf-8', 'fr_FR.utf8');
require_once dirname(__FILE__) . '/symfony/src/Symfony/Component/Yaml/Escaper.php';
require_once dirname(__FILE__) . '/symfony/src/Symfony/Component/Yaml/Unescaper.php';
require_once dirname(__FILE__) . '/symfony/src/Symfony/Component/Yaml/Inline.php';
require_once dirname(__FILE__) . '/symfony/src/Symfony/Component/Yaml/Dumper.php';
require_once dirname(__FILE__) . '/symfony/src/Symfony/Component/Yaml/Parser.php';

$tab = array('value' => round(54 / 72, 4));

var_dump($tab);

$dumper = new Symfony\Component\Yaml\Dumper();
$dump = $dumper->dump($tab, 1);

var_dump($dump);

$parser = new Symfony\Component\Yaml\Parser();
$parsed = $parser->parse($dump);

var_dump($parsed);

assert($parsed === $tab);

@romainneutron
Copy link
Contributor Author

Deplacement sur symfony/symfony

fabpot added a commit that referenced this pull request Jan 16, 2015
@fabpot
bug #13262 [Yaml] Improve YAML boolean escaping (petert82, larowlan)
4fea5b4 
This PR was merged into the 2.3 branch.

Discussion
----------

[Yaml] Improve YAML boolean escaping

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #13209
| License       | MIT
| Doc PR        | None

This PR ensures that PHP [values which would be interpreted as booleans][1] in older versions of the YAML spec are escaped with single quotes when dumped by the Dumper.

For example, dumping this:

```php
array(
    'country_code' => 'no',
    'speaks_norwegian' => 'y',
    'heating' => 'on',
)
```

Will produce this YAML:

```yaml
country_code: 'no'
speaks_norwegian: 'y'
heating: 'on'
```

[1]: http://yaml.org/type/bool.html

Commits
-------

8fa056b Inline private 'is quoting required' methods in Escaper
afe827a Merge pull request #2 from larowlan/patch-2
a0ec0fe Add comment as requested
1e0633e Merge pull request #1 from larowlan/patch-1
81a8090 Remove duplicate 'require'
3760e67 [Yaml] Improve YAML boolean escaping
fabpot added a commit that referenced this pull request Jan 16, 2015
@fabpot
bug #13262 [Yaml] Improve YAML boolean escaping (petert82, larowlan)
273324f 
This PR was merged into the 2.3 branch.

Discussion
----------

[Yaml] Improve YAML boolean escaping

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #13209
| License       | MIT
| Doc PR        | None

This PR ensures that PHP [values which would be interpreted as booleans][1] in older versions of the YAML spec are escaped with single quotes when dumped by the Dumper.

For example, dumping this:

```php
array(
    'country_code' => 'no',
    'speaks_norwegian' => 'y',
    'heating' => 'on',
)
```

Will produce this YAML:

```yaml
country_code: 'no'
speaks_norwegian: 'y'
heating: 'on'
```

[1]: http://yaml.org/type/bool.html

Commits
-------

8fa056b Inline private 'is quoting required' methods in Escaper
afe827a Merge pull request #2 from larowlan/patch-2
a0ec0fe Add comment as requested
1e0633e Merge pull request #1 from larowlan/patch-1
81a8090 Remove duplicate 'require'
3760e67 [Yaml] Improve YAML boolean escaping
teohhanhui pushed a commit to teohhanhui/Yaml that referenced this pull request Aug 7, 2015
@fabpot
bug #13262 [Yaml] Improve YAML boolean escaping (petert82, larowlan)
949dbf1 
This PR was merged into the 2.3 branch.

Discussion
----------

[Yaml] Improve YAML boolean escaping

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #13209
| License       | MIT
| Doc PR        | None

This PR ensures that PHP [values which would be interpreted as booleans][1] in older versions of the YAML spec are escaped with single quotes when dumped by the Dumper.

For example, dumping this:

```php
array(
    'country_code' => 'no',
    'speaks_norwegian' => 'y',
    'heating' => 'on',
)
```

Will produce this YAML:

```yaml
country_code: 'no'
speaks_norwegian: 'y'
heating: 'on'
```

[1]: http://yaml.org/type/bool.html

Commits
-------

8fa056b Inline private 'is quoting required' methods in Escaper
afe827a Merge pull request symfony#2 from larowlan/patch-2
a0ec0fe Add comment as requested
1e0633e Merge pull request symfony#1 from larowlan/patch-1
81a8090 Remove duplicate 'require'
3760e67 [Yaml] Improve YAML boolean escaping
symfony-splitter pushed a commit that referenced this pull request Sep 4, 2018
@fabpot
minor #28307 Mark ExceptionInterfaces throwable #2 (ostrolucky)
cb4f943 
This PR was merged into the 4.2-dev branch.

Discussion
----------

Mark ExceptionInterfaces throwable #2

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This has been reverted in beta of 4.1 because of lack of support in prophecy, which has been fixed since then (incl. release). Can be merged again.

References:
symfony/symfony#26702
symfony/symfony#27420
symfony/symfony#27419
phpspec/prophecy#412

ping @dunglas @ciaranmcnulty @dkarlovi @Wirone @teohhanhui @stof @nicolas-grekas @ondrejmirtes

Commits
-------

17c3675226 Mark ExceptionInterfaces throwable
symfony-splitter pushed a commit that referenced this pull request Aug 12, 2025
@nicolas-grekas
Merge branch '7.4' into 8.0
96b9c44 
* 7.4:
  [ObjectMapper] do not require mapping a target's required promoted property when not on source (#2)
  run tests with PHPUnit 12.3
  [GitHub] Update .github/PULL_REQUEST_TEMPLATE.md to remove SF 7.2 as it's not supported anymore
  [CI] fixed the Intl data tests actions Tests fails due to unknown option -v which is shorthand of the --verbose as per the phpunit its removed without any replacement sebastianbergmann/phpunit#5647 (comment)
  [Mailer] Fix expected exception message to include quotes around "http(s)://"
  [WebProfilerBundle] Fix toolbar not rendering after replacing it
  [Validator] (60455) Validate translations for Arabic (ar)
  (60474) Remove translation state attribute for Twig template validator in Ukrainian translation
  [VarDumper] Fix dumping objects from the DOM extension
  [Mailer] Add MicrosoftGraph API Transport
  [Yaml] Fix code style
  [Tests] Adapt testAddHtmlContentWithErrors to be HTML5 compliant
  Add friendly name in the `to` field
  [ObjectMapper] read source metadata before transform
  [HtmlSanitizer] Fix force_attributes not replacing existing attribute in initial data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@romainneutron