Skip to content

Add local:security:check back #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Add local:security:check back #46

merged 1 commit into from
Jan 18, 2022

Conversation

fabpot
Copy link
Contributor

@fabpot fabpot commented Jan 17, 2022

Closes #45

@fabpot
Copy link
Contributor Author

fabpot commented Jan 17, 2022

As an added bonus, I've added support for Github action.

if os.Getenv("GITHUB_WORKSPACE") != "" {
// Ran inside a Github action, export vulns
output, _ := security.Format(vulns, "raw_json")
terminal.Printf("::set-output name=vulns::%s", output)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if the json format is used to pipe it to something else ? shouldn't this be done only when outputting a human-readable format ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like GitHub action supports ::set-output being written to stderr (I tried that with echo "::set-output name=foo::bar">&2 in a simple workflow).
So it should be possible to write to stderr here and so supports every use cases possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #54

javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Jan 19, 2022
…eguiluz)

This PR was merged into the 4.4 branch.

Discussion
----------

Revert changes related to check:security command

This reverts #16356 because the `check:security` command has been re-added in symfony-cli/symfony-cli#46

Commits
-------

b140895 Revert changes related to check:security command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Re-add check:security command?
4 participants