Return scheme for undefined docker container #505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
requested changes
Jul 19, 2024
envs/envs_test.go
Outdated
| @@ -70,6 +70,27 @@ func (f fakeEnv) Local() bool { | |||
| return true | |||
| } | |||
|
|
|||
| func (s *ScenvSuite) TestGenericContainerExposesHostAndPort(c *C) { | |||
There was a problem hiding this comment.
This test passes even without your change. A test should be added in docker_test.go instead.
There was a problem hiding this comment.
I've deleted this test (to be honest, i've not ran the test because I haven't had a go development environment ready).
For a test in docker_test.go I would propose to test the docker integration more sophisticated (like with testcontainers, so we can test the interaction with real containers). I'm willing to send a PR, but it would take a day or two.
There was a problem hiding this comment.
Ok, let's commit as is for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #504
In the issue I talked about to setting the scheme to "tcp". While it would work, it is not entirely accurate. So I've returned the scheme
undefined(as a string), which matches closer to what it is actually happening.