Skip to content

feat: consider php.ini from Nix #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shyim
Copy link
Contributor

@shyim shyim commented Oct 26, 2024

When you create a php.ini in local dir and use PHP from nix. All extensions are gone as Nix sets a PHP_INI_SCAN_DIR

@tucksaun
Copy link
Member

tucksaun commented Dec 7, 2024

shouldn’t this work out of the box as we preprend the directory to any PHP_INI_SCAN_DIR already set?

@shyim
Copy link
Contributor Author

shyim commented Dec 9, 2024

The problem is that the Nix PHP binary itself is an wrapper with sets PHP_INI_SCAN_DIR

@tucksaun
Copy link
Member

tucksaun commented Dec 9, 2024

If this is in the Nix wrapper, it is after we set PHP_INI_SCAN_DIR.
We don't override, instead, we prepend our value to preserve the original value of PHP_INI_SCAN_DIR.

It looks like Nix had something similar but decided to change their behavior in NixOS/nixpkgs#221845.
I don't think it is our responsibility to ship a really specific Nix workaround based on their controversial decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants