Skip to content

fix: let system level set env win #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: let system level set env win #531

wants to merge 1 commit into from

Conversation

shyim
Copy link
Contributor

@shyim shyim commented Oct 26, 2024

when I have a .env

foo=1

and then do:

export foo=my-value

symfony php -i | grep foo

I see it is set to 1. and this is wrong. When I export a env variable it should win

@shyim shyim mentioned this pull request Oct 26, 2024
Open
@tucksaun
Copy link
Member

tucksaun commented Dec 7, 2024

I’m wondering if instead we should not change the logic in Executor.Execute() to force the current environment to be appended instead of being preprended.
/cc @nicolas-grekas wdyt?

@nicolas-grekas
Copy link
Contributor

No opinion about the implementation, but the description of the issue looks correct to me, the precedence needs a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shyim @tucksaun @nicolas-grekas