Skip to content

feat: add support for .symfony.local.dist.yaml and .symfony.local.override.yaml config files #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 12, 2025
Merged

feat: add support for .symfony.local.dist.yaml and .symfony.local.override.yaml config files #611

merged 2 commits into from
Jun 12, 2025

Conversation

tucksaun
Copy link
Member

@tucksaun tucksaun commented May 12, 2025 •
edited
Loading

fix #606

still WIP but opening early so that one can try it locally and that we can discuss some details

@tucksaun tucksaun force-pushed the feat/config-dist-override branch 4 times, most recently from d95bfd2 to f751994 Compare May 12, 2025 18:17
@tucksaun tucksaun mentioned this pull request May 12, 2025
Closed
@tucksaun tucksaun force-pushed the feat/config-dist-override branch 2 times, most recently from 529619e to 6e31c5e Compare May 12, 2025 19:49
@Kocal
Copy link
Contributor

Kocal commented May 12, 2025 •
edited
Loading

What's the file .symfony.local.override.yaml for?

@tucksaun
Copy link
Member Author

What's the file .symfony.local.override.yaml for?

While implementing the feature, I figured similar tools (Docker Compose for instance) also uses an .override.yaml pattern and because support it is only a matter of adding a loop iteration I added. This way, one can choose what they prefer.

@smnandre
Copy link

tested: works perfectly for me! Thanks a lot @tucksaun

@fabpot
Copy link
Contributor

fabpot commented May 24, 2025

Still WIP @tucksaun?

@tucksaun
Copy link
Member Author

@fabpot didn't get a chance to give more try lately. should be this week

@tucksaun tucksaun force-pushed the feat/config-dist-override branch from 6e31c5e to cd1868e Compare June 12, 2025 07:06
@tucksaun
Copy link
Member Author

I think we are good 🎉
But this is quite some change so please review and test thoroughly 🙏

@tucksaun
Copy link
Member Author

tucksaun commented Jun 12, 2025 •
edited
Loading

Also, before merging we need to decide whether we want to support .symfony.local.dist.yaml or .symfony.local.override.yaml or both. (I'm fine with both with current codebase)

@fabpot fabpot merged commit 3d44daa into symfony-cli:main Jun 12, 2025
2 checks passed
@tucksaun tucksaun deleted the feat/config-dist-override branch June 12, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC] Look for .dist configuration files ?
4 participants
@tucksaun @Kocal @smnandre @fabpot