do not truncate log files on each LogWriter calls #626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
reviewed
Jun 12, 2025
We used to have a single concurrent usage of the `LogWriter`, but this is not the case anymore since b29665f. Because of this we now loose the runner logs as he file is being truncated during the `buildCmd` call when the LogWrited is fetched. To fix this i propose to instantiate the LogWriter once which will effectively truncate the file only once per `server:start` launch.
a97d465 to
606fd41
Compare
|
Thank you @tucksaun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to have a single concurrent usage of the
LogWriter, but this is not the case anymore since b29665f. Because of this, we can lose some logs (the runner ones for instance) as the file is being truncated during thebuildCmdcall when theLogWriteis fetched.To fix this, I propose to instantiate the
LogWriteronce, which will effectively truncate the file only once perserver:startlaunch.