Typos and URLs fixes #45
Conversation
| @@ -104,5 +104,5 @@ It replaces components of the bundle where needed to be compatible with PHPCR. | |||
|
|
|||
| The following picture shows where we use our own components (blue): | |||
|
|
|||
| .. image:: ../images/bundles/classdiagram.jpg | |||
| .. image:: /images/bundles/classdiagram.jpg | |||
There was a problem hiding this comment.
no, this would break on symfony.com, the paths need to be relative.
There was a problem hiding this comment.
I took the example in here: https://github.com/symfony/symfony-docs/edit/master/book/http_fundamentals.rst
If you look at line 56, there is an absolute URL. I think this is what is breaking the image in the PDF...
There was a problem hiding this comment.
afaik we had to change all our internal links to relative to make it work in symfony.com as we are one level below.
@fabpot can you clarify how we should include images in the symfony-cmf docs so that it works on both web and pdf?
|
thanks for fixing those typos. can you change the thing about the image inclusion, then we can merge. |
|
look like you also need to rebase |
|
@adou600 ping |
|
we still don't know how to properly include the image so it works both in pdf and html. if we don't have a solution soon, we might want to remove that change and merge the rest as the rest is just fine. |
|
make it work for the HTML and I will fix the PDF (can you open a ticket for it on symfony-docs with the website tag?). |
I went through all the documentation and have seen a few typos and URLs problems...
The documentation is really well done, this is great!