-
Notifications
You must be signed in to change notification settings - Fork 156
Conversation
dantleech
commented
Aug 10, 2014
Q | A |
---|---|
Doc fix? | no |
New docs? | no0) |
Applies to | all (or 2.3+) |
Fixed tickets | #522 |
install: | ||
- "pip install -q -r requirements.txt --use-mirrors" | ||
- git submodule init | ||
- git submodule update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Travis takes care of this already, so you can remove both commands (otherwise, they will be run twice). See symfony/symfony-docs#3711
OK, if the testes pass I will merge. |
do we have anywhere a doc how to build the docs? did not find it on a quick search - if there is, we need to adjust that to mention git submodule install/update |
It's in symfony.com/doc/current/contributing/documentation |
is the main symfony doc using the submodule already? (did not find "build documentation" in the toc) btw, this PR needs a rebase. |
Yes, we never did it the other way.
http://symfony.com/doc/current/contributing/documentation/format.html#testing-documentation |
alright, then i am +1 to merge this. @dantleech can you rebase? |
rebased it :) |
fabpot sphinx exensions as submodule