Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

fabpot sphinx exensions as submodule #535

Merged
merged 2 commits into from
Aug 11, 2014
Merged

fabpot sphinx exensions as submodule #535

merged 2 commits into from
Aug 11, 2014

Conversation

dantleech
Copy link
Member

Q A
Doc fix? no
New docs? no0)
Applies to all (or 2.3+)
Fixed tickets #522

install:
- "pip install -q -r requirements.txt --use-mirrors"
- git submodule init
- git submodule update
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis takes care of this already, so you can remove both commands (otherwise, they will be run twice). See symfony/symfony-docs#3711

@dantleech
Copy link
Member Author

OK, if the testes pass I will merge.

@dbu
Copy link
Member

dbu commented Aug 11, 2014

do we have anywhere a doc how to build the docs? did not find it on a quick search - if there is, we need to adjust that to mention git submodule install/update

@wouterj
Copy link
Member

wouterj commented Aug 11, 2014

It's in symfony.com/doc/current/contributing/documentation

@dbu
Copy link
Member

dbu commented Aug 11, 2014

is the main symfony doc using the submodule already? (did not find "build documentation" in the toc)

btw, this PR needs a rebase.

@wouterj
Copy link
Member

wouterj commented Aug 11, 2014

is the main symfony doc using the submodule already?

Yes, we never did it the other way.

(did not find "build documentation" in the toc)

http://symfony.com/doc/current/contributing/documentation/format.html#testing-documentation

@dbu
Copy link
Member

dbu commented Aug 11, 2014

alright, then i am +1 to merge this.

@dantleech can you rebase?

@wouterj
Copy link
Member

wouterj commented Aug 11, 2014

rebased it :)

dbu added a commit that referenced this pull request Aug 11, 2014
fabpot sphinx exensions as submodule
@dbu dbu merged commit 826d52e into master Aug 11, 2014
@dbu dbu deleted the exts_as_submodule branch August 11, 2014 09:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants