Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

Preparing for 1.2 release #580

Merged
merged 4 commits into from
Oct 25, 2014
Merged

Preparing for 1.2 release #580

merged 4 commits into from
Oct 25, 2014

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Oct 5, 2014

No description provided.

menu item voters), you can tag services with ``cmf_request_aware`` to have a
kernel listener inject the request. Any class used in such a tagged service
must have the ``setRequest`` method or you will get a fatal error::
When working with the CMF in Symfony 2.2 and you have services that need the
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

am I correct that this isn't related to a specific CMF version, but just to the CMF in general?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually no, cmf 1.1+ dropped the symfony 2.2 support so this is only relevant for cmf 1.0. which probably means we could drop the documentation of this tag.

if we do what we promised in the .. caution::, we actually should remove the tag from core bundle alltogether. in the interest of BC i think we should leave it in until 2.0 - but not have any documentation anymore, its just legacy.

@dbu
Copy link
Member

dbu commented Oct 7, 2014

thanks wouter.

@wouterj
Copy link
Member Author

wouterj commented Oct 25, 2014

Dropped documentation of the request aware tag and reverted changes in the tutorial, that'll be fixed by #595 I also fixed some more versions. I didn't test them using composer, but they should be correct.

wouterj added a commit that referenced this pull request Oct 25, 2014
@wouterj wouterj merged commit 28bd76b into dev Oct 25, 2014
@wouterj wouterj deleted the prepare-1.2 branch October 25, 2014 15:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants