This repository was archived by the owner on Sep 16, 2021. It is now read-only.
[WIP] Tutorial Updates for 1.2 #595
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| register your new site initializer: | ||
| Now: | ||
|
|
||
| 1. *Remove* the old initializer service, |
There was a problem hiding this comment.
I always miss this part and there was a user that got stuck with this too, so I have tried to make it a bit more obvious that you need to remove the old initialiser.
There was a problem hiding this comment.
maybe say "Remove the initializer service you created in the previous chapter, ..."? "old" is not very specific.
|
looks good |
b64373c to
9a1f858
Compare
|
Updated. Added the |
| "doctrine/phpcr-bundle": "1.1.*", | ||
| "doctrine/phpcr-odm": "1.0.*", | ||
| "jackalope/jackalope-doctrine-dbal": "1.0.0" | ||
| "doctrine/phpcr-bundle": "~1.2.0", |
There was a problem hiding this comment.
should we just say ~1.2,>=1.2.1 ?
|
Apart from widing the versions, is everything correct here? (btw, this should be rebased on dev) |
9a1f858 to
2149861
Compare
|
Updated |
|
@wouterj good to merge as far as I'm concerned |
|
Thanks @dantleech. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates and improvements for 1.2.
Note there is a problem in that the RoutingAutoBundle intializes before the initializer that we create in the last chapter, causing it to fail.
We need to add support for initializer priority: doctrine/DoctrinePHPCRBundle#173