Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

documenting the sitemap features #683

Merged
merged 1 commit into from
Jul 31, 2015
Merged

documenting the sitemap features #683

merged 1 commit into from
Jul 31, 2015

Conversation

dbu
Copy link
Member

@dbu dbu commented Jul 24, 2015

documenting symfony-cmf/seo-bundle#225 assuming that symfony-cmf/seo-bundle#239 is also merged.

fix #681

@dbu dbu force-pushed the seo-sitemap-doc branch 2 times, most recently from 8ce5200 to f832daf Compare July 24, 2015 12:29
@dbu
Copy link
Member Author

dbu commented Jul 24, 2015

@ElectricMaxxx may i ask you to review this one as well?

@dbu dbu removed the wip/poc label Jul 24, 2015
~~~~~~~~~~~

.. versionadded:: 1.3
Support for sitemaps was added in version 1.3 of the SeoBundle.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"was introduced in SeoBundle 1.3."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep our last version was 1.1.

Copy link
Member Author

@dbu dbu Jul 27, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ElectricMaxxx
Copy link
Member

Except the version thing, this documentation looks very good and explains the complecity of the configuration in a very short way. Great.

@dbu dbu force-pushed the seo-sitemap-doc branch from f832daf to 35cce67 Compare July 27, 2015 06:43
@dbu
Copy link
Member Author

dbu commented Jul 27, 2015 via email

@ElectricMaxxx
Copy link
Member

@dbu this is your friendly reminder service: please be aware of the changes made by symfony-cmf/seo-bundle#243 thanks.

@dbu dbu force-pushed the seo-sitemap-doc branch from 0cfde44 to d2708d4 Compare July 29, 2015 05:46
@dbu
Copy link
Member Author

dbu commented Jul 29, 2015

updated for default sitemaps

@dbu
Copy link
Member Author

dbu commented Jul 31, 2015

@ElectricMaxxx ok if we merge this and then document the features we are now cleaning up in separate PRs? would be more manageable imho.

@ElectricMaxxx
Copy link
Member

👍 would be nice if this is merged, an i can use the reference on my
PR :-)
Am 31.07.2015 um 15:55 schrieb David Buchmann:

@ElectricMaxxx ok if we merge this and then document the features we are now cleaning up in separate PRs? would be more manageable imho.


Reply to this email directly or view it on GitHub:
#683 (comment)

dbu added a commit that referenced this pull request Jul 31, 2015
@dbu dbu merged commit 9bc4682 into master Jul 31, 2015
@dbu dbu deleted the seo-sitemap-doc branch July 31, 2015 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

document SeoBundle sitemap configuration and extending
4 participants