This repository was archived by the owner on Sep 16, 2021. It is now read-only.
[content-bundle] change doc to best practices #795
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
approved these changes
Jan 25, 2017
| @@ -72,6 +73,7 @@ Here is an example configuration for the FOSRestBundle. | |||
| .. code-block:: xml | |||
|
|
|||
| <?xml version="1.0" encoding="UTF-8" ?> | |||
| <!-- app/config/config.xml --> | |||
There was a problem hiding this comment.
should be before the doctype thing
There was a problem hiding this comment.
oh, ok. if that is the convention, i can change. but that would mean its not valid xml anymore. the doctype must be the very first thing in an xml file afaik.
There was a problem hiding this comment.
Yeah, that's correct. However, one is not supposed to copy the file comment (e.g. no PHP file is valid as well, as there is no <?php).
|
fixed and rebased in #810 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.