This repository was archived by the owner on Sep 16, 2021. It is now read-only.
[phpcr-odm] change doc to best practices #798
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
reviewed
Jan 25, 2017
| // app/config/config.php | ||
| use AppBundle\EventListener\SearchIndexer; | ||
| use AppBundle\EventListener\MyListener; | ||
|
|
||
| $container | ||
| ->register( | ||
| 'acme_search.listener.search', |
| class: Doctrine\Bundle\PHPCRBundle\Initializer\GenericInitializer | ||
| arguments: | ||
| - AcmeContentBundle Basepaths | ||
| - App Basepaths | ||
| - [ "/my/content", "/my/menu" ] |
There was a problem hiding this comment.
there should be no spaces at the inside of []
| '%acme.cnd%', | ||
| ) | ||
| )); | ||
| 'Doctrine\Bundle\PHPCRBundle\Initializer\GenericInitializer', [ |
| @@ -117,13 +117,14 @@ depending on the locale. | |||
| .. code-block:: php | |||
|
|
|||
| <?php | |||
| 'dms' => array( | ||
| 'configuration_id' => 'magnolia.odm_configuration', | ||
| 'mappings' => [ | ||
| 'MagnoliaBundle' => null, |
There was a problem hiding this comment.
it needs to be two different bundles. rather than making this FooBundle i took a real example. is that ok or should i explain more above the example what we are doing here?
There was a problem hiding this comment.
Ah, well. If we need 2 different bundles, it's perfect this way (didn't read the articles, just quickly looked at the diff)
There was a problem hiding this comment.
i think the confusion does highlight less then ideal documentation. i now xplain a bit what we do above the example, to make this more understandable.
|
fixing things against 2.0 in #807 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.